Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 08 Nov 2019 15:29:49 +0000
From:      bugzilla-noreply@freebsd.org
To:        elastic@FreeBSD.org
Subject:   [Bug 229322] net/py-urllib3: Update to 1.24.3 (or 1.25.6 if possible)
Message-ID:  <bug-229322-37421-8PdRZrOjI6@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-229322-37421@https.bugs.freebsd.org/bugzilla/>
References:  <bug-229322-37421@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D229322

--- Comment #21 from Kai Knoblich <kai@FreeBSD.org> ---
Created attachment 208975
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D208975&action=
=3Dedit
py-urllib-1.25.6.patch

Attached is a new patch that updates net/py-urllib3 to 1.25.6. It contains =
also
following modifications:

- Convert the dependencies which are declared as extra dependencies in setu=
p.py
into OPTIONS
- Set the options as default that were used by the previous RUN_DEPENDS
- Update the TEST_DEPENDS and add a "do-test" target to make future QA easi=
er
- Remove the pkg-message, the related variable and patch as the info about =
the
broken IPv6 support of net/py-socks (was broken with 1.5.7) is obsolete.
- Remove the limitation for security/py-certifi. It has no Python version
restriction in setup.py and it's more likely a remnant of the time when the=
re
were separate versions of www/py-urllib3. See ports r443069 for some detail=
s.
- Separate USES block

QA:
~~~
- poudriere (11.3-, 12.0, 12.1-RELEASE, 13.0-CURRENT@r353466 amd64) for each
py27 + py36 flavor -> OK
- "Mini" Exp-Runs with 11.3-, 12.0- and 12.1-RELEASE against all direct
consumers of net/py-urllib3 and www/py-requests -> OK

Results of "make test" with all tests enabled:

11.3-RELEASE, Python 3.6:
> 1061 passed, 245 skipped, 121 warnings in 29.94 seconds

11.3-RELEASE, Python 2.7:
> 1059 passed, 247 skipped, 86 warnings in 34.71 seconds

12.0-, 12.1-RELEASE, 13.0-CURRENT@r353466, Python 3.6:
> 1 failed, 1130 passed, 175 skipped, 125 warnings in 51.85 seconds

12.0-, 12.1-RELEASE, 13.0-CURRENT@r353466, Python 2.7:=20
> 1 failed, 1128 passed, 177 skipped, 86 warnings in 51.86 seconds

- With FreeBSD 11.3 there are many skipped tests because of the OpenSSL ver=
sion
in base that has no TLSv3 support.

- With FreeBSD >=3D 12.0 one test permanently fails (=3D "test_ssl_read_tim=
eout")
but IMHO this shouldn't be a blocker because that test also fails with
net/py-urllib3 1.22. But I'll do some investigation why it fails but I alre=
ady
excluded that test in the attached patch.


TODO:
~~~~~
- In-depth checking
- Investigate why 'test_ssl_read_timeout' fails
- Request an Exp-Run?

--=20
You are receiving this mail because:
You are on the CC list for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-229322-37421-8PdRZrOjI6>