From owner-cvs-ports@FreeBSD.ORG Sun Nov 13 10:46:07 2011 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C8AEE106566B; Sun, 13 Nov 2011 10:46:07 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id 69A4B8FC0C; Sun, 13 Nov 2011 10:46:07 +0000 (UTC) Received: by iakl21 with SMTP id l21so6673883iak.13 for ; Sun, 13 Nov 2011 02:46:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=YGA+DyQjjcOjevIenrhMFDvGrlKIzEIt2J52pCFX7UY=; b=CNKMvqb+IIAEnYUeWIpNWIN9/aYsZ7TFyrHYgW0oahK2+IAKgubJHaatRcNHLB1V9D ecULxrNFKS2rwhGDU/7RuN2o64SeKOZtkeKzFsD3FfhBr0wmTfh1muMFEoDX3wfPYRmx tkTLZY4RBfa0Lg5xKlYKIHYd4kdGejpqrAM1I= Received: by 10.231.63.209 with SMTP id c17mr4751133ibi.65.1321181166093; Sun, 13 Nov 2011 02:46:06 -0800 (PST) MIME-Version: 1.0 Sender: utisoft@gmail.com Received: by 10.231.11.140 with HTTP; Sun, 13 Nov 2011 02:45:35 -0800 (PST) In-Reply-To: <201111130956.pAD9u85M053975@repoman.freebsd.org> References: <201111130956.pAD9u85M053975@repoman.freebsd.org> From: Chris Rees Date: Sun, 13 Nov 2011 10:45:35 +0000 X-Google-Sender-Auth: pBFFXOVf2ub0rdYN9cCOY35Q7MQ Message-ID: To: Baptiste Daroussin , Ed Schouten , matthew@cashdollar.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/shells/zsh/files patch-Src_watch.c X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Nov 2011 10:46:07 -0000 On 13 November 2011 09:56, Baptiste Daroussin wrote: > bapt =A0 =A0 =A0 =A02011-11-13 09:56:08 UTC > > =A0FreeBSD ports repository > > =A0Added files: > =A0 =A0shells/zsh/files =A0 =A0 patch-Src_watch.c > =A0Log: > =A0- Fix build for badly upgraded systems which have both utmp.h and utmp= x.h > > =A0PR: =A0 =A0 =A0 =A0 =A0 =A0 ports/156263 =A0http://www.FreeBSD.org/cgi= /query-pr.cgi?pr=3D156263 > =A0Submitted by: =A0 Matthew Cashdollar > =A0Feature safe: =A0 yes > Fixing it here will only mask the problem-- why are we adding a fix to support a broken system? The proper solution is to rm utmp.h in that system, is it not? I suggest a different patch at [1]. Chris [1] http://www.bayofrum.net/~crees/patches/zsh-utmpx-fix.diff.txt [removing the patchfile too]