From owner-freebsd-ports@FreeBSD.ORG  Mon May 16 04:18:54 2011
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 298B3106566C;
	Mon, 16 May 2011 04:18:54 +0000 (UTC)
	(envelope-from wblock@wonkity.com)
Received: from wonkity.com (wonkity.com [67.158.26.137])
	by mx1.freebsd.org (Postfix) with ESMTP id DFEA68FC13;
	Mon, 16 May 2011 04:18:53 +0000 (UTC)
Received: from wonkity.com (localhost [127.0.0.1])
	by wonkity.com (8.14.4/8.14.4) with ESMTP id p4G4Ir3A020452;
	Sun, 15 May 2011 22:18:53 -0600 (MDT)
	(envelope-from wblock@wonkity.com)
Received: from localhost (wblock@localhost)
	by wonkity.com (8.14.4/8.14.4/Submit) with ESMTP id p4G4IrR6020449;
	Sun, 15 May 2011 22:18:53 -0600 (MDT)
	(envelope-from wblock@wonkity.com)
Date: Sun, 15 May 2011 22:18:53 -0600 (MDT)
From: Warren Block <wblock@wonkity.com>
To: Doug Barton <dougb@freebsd.org>
In-Reply-To: <4DD09B45.9070306@FreeBSD.org>
Message-ID: <alpine.BSF.2.00.1105152216460.20421@wonkity.com>
References: <4DD09B45.9070306@FreeBSD.org>
User-Agent: Alpine 2.00 (BSF 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7
	(wonkity.com [127.0.0.1]); Sun, 15 May 2011 22:18:53 -0600 (MDT)
Cc: FreeBSD Ports <freebsd-ports@freebsd.org>
Subject: Re: proper use of bsd.port.options.mk
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 16 May 2011 04:18:54 -0000

On Sun, 15 May 2011, Doug Barton wrote:

> I'm confused (yeah, I know, nothing new about that). From 
> ports/Mk/bsd.port.options.mk:
>
> # usage:
> #
> #       .include "bsd.port.options.mk"
> #       <deal with user options>
> #       .include "bsd.port.pre.mk"
> #       <other work, including adjusting dependencies>
> #       .include "bsd.port.post.mk"
>
>
> However the ports I've looked at so far all do:
>
> OPTIONS=	blah
>
> .include <bsd.port.options.mk>
>
> blah
>
> .include <bsd.port.mk>
> EOF
>
> I assume that this method works, since it seems like so many ports use it. 
> Should the notes in options.mk be updated?

Yes, it should be updated.  See examples "5.8 Simple use of OPTIONS" and 
"5.9 Old style use of OPTIONS" in the Porter's Handbook:

http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-options.html