From owner-freebsd-arm@FreeBSD.ORG  Fri Feb 12 16:56:44 2010
Return-Path: <owner-freebsd-arm@FreeBSD.ORG>
Delivered-To: freebsd-arm@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 77C79106568F;
	Fri, 12 Feb 2010 16:56:44 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 3B7268FC12;
	Fri, 12 Feb 2010 16:56:44 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o1CGowCb045394;
	Fri, 12 Feb 2010 09:50:58 -0700 (MST) (envelope-from imp@bsdimp.com)
Date: Fri, 12 Feb 2010 09:51:04 -0700 (MST)
Message-Id: <20100212.095104.655406241961872938.imp@bsdimp.com>
To: andrew@fubar.geek.nz
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <20100212151043.2e62ca78@fubar.geek.nz>
References: <20100211223402.621a8c89@fubar.geek.nz>
	<4B7409B2.3040107@freebsd.org>
	<20100212151043.2e62ca78@fubar.geek.nz>
X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: freebsd-arm@FreeBSD.org, rpaulo@FreeBSD.org
Subject: Re: New S3C24x0 patch
X-BeenThere: freebsd-arm@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting FreeBSD to the StrongARM Processor <freebsd-arm.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
	<mailto:freebsd-arm-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arm>
List-Post: <mailto:freebsd-arm@freebsd.org>
List-Help: <mailto:freebsd-arm-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
	<mailto:freebsd-arm-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Feb 2010 16:56:44 -0000

In message: <20100212151043.2e62ca78@fubar.geek.nz>
            Andrew Turner <andrew@fubar.geek.nz> writes:
: On Thu, 11 Feb 2010 13:44:18 +0000
: Rui Paulo <rpaulo@freebsd.org> wrote:
: > This looks good. Before this can be committed you need to:
: > * fix the lines passing the 80 column mark
: > * remove debugging printfs
: I've fixed these problems. There is a new patch at [1].
: 
: Andrew
: 
: [1]
: http://fubar.geek.nz/files/freebsd/s3c2xx0/freebsd-s3c24x0-20100212.diff

Hey Andrew,

These patches look better.  They are looking pretty good, but I'd like
a few days to look them over and comment on them.  There's a number of
little things I'd like to see fixed and maybe one or two big things
(or maybe not, I just need to think through some of the stuff I saw).

Warner