Date: Tue, 23 Oct 2012 15:15:48 -0700 From: mdf@FreeBSD.org To: Andre Oppermann <andre@freebsd.org> Cc: src-committers@freebsd.org, Bruce Evans <brde@optusnet.com.au>, John Baldwin <jhb@freebsd.org>, svn-src-user@freebsd.org Subject: Re: svn commit: r241889 - in user/andre/tcp_workqueue/sys: arm/arm cddl/compat/opensolaris/kern cddl/contrib/opensolaris/uts/common/dtrace cddl/contrib/opensolaris/uts/common/fs/zfs ddb dev/acpica dev/... Message-ID: <CAMBSHm-NYtqL71_5zvKj5RNO%2B-ryc6av760eSwBncgP=1d7%2BmQ@mail.gmail.com> In-Reply-To: <5086AC94.2090700@freebsd.org> References: <201210221418.q9MEINkr026751@svn.freebsd.org> <20121023032743.K2804@besplex.bde.org> <508664C7.3080206@freebsd.org> <201210230853.56549.jhb@freebsd.org> <5086AC94.2090700@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Oct 23, 2012 at 7:41 AM, Andre Oppermann <andre@freebsd.org> wrote: > Struct mtx and MTX_SYSINIT always occur as pair next to each other. That doesn't matter. Language basics like variable definitions should not be obscured by macros. It either takes longer to figure out what a variable is (because one needs to look up the definition of the macro) or makes it almost impossible (because now e.g. cscope doesn't know this is a variable definition. Thanks, matthew
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMBSHm-NYtqL71_5zvKj5RNO%2B-ryc6av760eSwBncgP=1d7%2BmQ>