Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 23 May 2021 21:35:23 +0300
From:      Dmitry Marakasov <amdmi3@amdmi3.ru>
To:        Gerald Pfeifer <gerald@pfeifer.com>
Cc:        ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Subject:   Re: git: 1df3a9e009d5 - main - www/trafficserver: switch to options helpers
Message-ID:  <YKqga4%2Bw7u64lmVk@hades.panopticon>
In-Reply-To: <76121cdf-5358-6a50-60c3-6685e03cc87d@pfeifer.com>
References:  <202105191041.14JAf4v3047169@gitrepo.freebsd.org> <76121cdf-5358-6a50-60c3-6685e03cc87d@pfeifer.com>

next in thread | previous in thread | raw e-mail | index | archive | help
* Gerald Pfeifer (gerald@pfeifer.com) wrote:

> >     www/trafficserver: switch to options helpers
> >     
> >     Approved by:    portmgr blanket
> 
> The following three aren't related to options helpers, though, but the
> pre-existing "OPTIONS_SUB=yes", are they?

I include OPTIONS_SUB into options helpers.

> > -PLIST_SUB+=	MEMCACHED=""
> > -.else
> > -PLIST_SUB+=	MEMCACHED="@comment "
> 
> > -PLIST_SUB+=	IMAGEMAGICK=""
> > -.else
> > -PLIST_SUB+=	IMAGEMAGICK="@comment "
> 
> > -PLIST_SUB+=	WCCP=""
> :
> > -.else
> > -PLIST_SUB+=	WCCP="@comment "
> 
> That is, these were redundant before already?

Yes, these were redundant in presence of OPTIONS_SUB.

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru  ..:              https://github.com/AMDmi3




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YKqga4%2Bw7u64lmVk>