From owner-freebsd-bugs Mon Apr 17 9:30: 5 2000 Delivered-To: freebsd-bugs@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (Postfix) with ESMTP id 6E4B037B886 for ; Mon, 17 Apr 2000 09:30:02 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.9.3/8.9.2) id JAA30446; Mon, 17 Apr 2000 09:30:01 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Date: Mon, 17 Apr 2000 09:30:01 -0700 (PDT) Message-Id: <200004171630.JAA30446@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: Steve Price Subject: re: bin/16271 (fwd) Reply-To: Steve Price Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org The following reply was made to PR bin/16271; it has been noted by GNATS. From: Steve Price To: freebsd-gnats-submit@freebsd.org Cc: Subject: re: bin/16271 (fwd) Date: Mon, 17 Apr 2000 11:25:23 -0500 (CDT) ---------- Forwarded message ---------- Date: Thu, 30 Mar 2000 21:44:22 -0800 (PST) From: Jin Guojun To: freebsd-bugs@FreeBSD.ORG Subject: re: bin/16271 This problem also exists in 4.0 release. The patch is very simple, and the concept is clear. Can we fix this problem with apply the following patch? Thanks, -Jin } Description } } an unsinged len is used to compare with signed expression, } this causes core dump because the (len > 0) always true, } so loop never ends. } patch: *** contrib/nvi/ex/ex_subst.c Thu Oct 31 22:45:30 1996 --- /tmp/ex_subst.c.new Thu Mar 30 21:35:24 2000 *************** *** 1177,1183 **** size_t *plenp; int *replacedp; { ! size_t blen, len; int lastdollar; char *bp, *p, *t; --- 1177,1184 ---- size_t *plenp; int *replacedp; { ! size_t blen; ! int len; int lastdollar; char *bp, *p, *t; To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message