From owner-freebsd-ports@FreeBSD.ORG Sun Jan 23 16:59:39 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2D8BC106566B for ; Sun, 23 Jan 2011 16:59:39 +0000 (UTC) (envelope-from me@janh.de) Received: from mailhost.uni-hamburg.de (mailhost.uni-hamburg.de [134.100.32.155]) by mx1.freebsd.org (Postfix) with ESMTP id A25E48FC16 for ; Sun, 23 Jan 2011 16:59:38 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mailhost.uni-hamburg.de (Postfix) with ESMTP id BF417900B3; Sun, 23 Jan 2011 17:59:37 +0100 (CET) X-Virus-Scanned: by University of Hamburg (RRZ/mailhost) Received: from mailhost.uni-hamburg.de ([127.0.0.1]) by localhost (mailhost.uni-hamburg.de [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 1p7LL3PlVoMM; Sun, 23 Jan 2011 17:59:37 +0100 (CET) Received: from nb981.math (f054010244.adsl.alicedsl.de [78.54.10.244]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: fmjv004) by mailhost.uni-hamburg.de (Postfix) with ESMTPSA id 6AD979003D; Sun, 23 Jan 2011 17:59:37 +0100 (CET) Message-ID: <4D3C5E77.3000702@janh.de> Date: Sun, 23 Jan 2011 17:59:35 +0100 From: Jan Henrik Sylvester User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.13) Gecko/20101219 Thunderbird/3.1.7 MIME-Version: 1.0 To: Chris Rees References: <4D39FEBA.3000806@janh.de> <4D3AF40E.7090301@janh.de> <4D3C565A.7060009@janh.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: ports-list freebsd Subject: Re: Xournal: Please, help me with my first port X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Jan 2011 16:59:39 -0000 On 01/23/2011 17:35, Chris Rees wrote: > On 23 January 2011 16:24, Jan Henrik Sylvester wrote: >> On 01/23/2011 11:42, Chris Rees wrote: >>> >>> Take a look at the new patch so far; I'm still working on Busybox at >>> the moment, so I'm afraid I can't step too much more through it, but >> >> Just a question about what you did so far: Why the >> "CONFIGURE_ARGS+=--prefix=${PREFIX}"? I have tested with a different PREFIX >> before and it was successful -- that is what the second part of the >> REINPLACE accomplished. What does your line improve? >> >> Or is it a first step, if I wanted to make the port DATADIR-safe? Should I include that line? (I have just retested: The port installs to the correct PREFIX without that line and seems to be working fine.) >> I believe that it is correct what portlint says: "If and only if your port >> is DATADIR-safe (that is, a user can override DATADIR when building this >> port and the port will still work correctly) consider using DATADIR macro; >> if you are unsure if this port is DATADIR-safe, then ignore this warning". >> Thus, there should not be DATADIR in my pkg-plist as long as the port is not >> DATADIR-safe. >> > > Perhaps you should ignore the portlint warnings and leave it as > share/xournal then. Thanks. BTW: I am going to ignore your capitalization of "makefile" in the first line, too, since it is non-capitalized in the porters handbook and 20210 over 240 ports go for the non-capitalized variant. Cheers, Jan Henrik