From owner-freebsd-ports@FreeBSD.ORG Sun Jul 1 17:49:12 2012 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 965C41065670 for ; Sun, 1 Jul 2012 17:49:12 +0000 (UTC) (envelope-from decke@bluelife.at) Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id 135EA8FC12 for ; Sun, 1 Jul 2012 17:49:11 +0000 (UTC) Received: by bkwj5 with SMTP id j5so2840614bkw.13 for ; Sun, 01 Jul 2012 10:49:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bluelife.at; s=google; h=from:reply-to:to:subject:x-mailer:references:in-reply-to :content-type:content-id:date:message-id:mime-version :content-transfer-encoding; bh=EyBgwortir88FTVd/8qyn3PS88YQJDJKXuVDadnAZHs=; b=TbVghA4h6H7LoyxuXK/8nrMxOOkDnsLElc9Kab+tODokpNsLWAI4lpOVT3xk1TO1qX M7VBFieFzCvRp8G0CkgO72ELyIlSnPvpaLfijou17NY9cA0jn2zh3XM/I1Bbbd6DPG0i Bs+CZ1tuv3GJtN5lZy6B5286XE83AWq4aGUw8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:reply-to:to:subject:x-mailer:references:in-reply-to :content-type:content-id:date:message-id:mime-version :content-transfer-encoding:x-gm-message-state; bh=EyBgwortir88FTVd/8qyn3PS88YQJDJKXuVDadnAZHs=; b=BqtRSnAaT2qC76dWAUhgMLGVYJuOk4gzjq2WbXopOPfGA/dYBk0s9u9S9nbZGAoQXL pf7QP7cOYVZrKqWu9ypsP5NBxLTgNxiFz8oftGM7Cuudf0UQQlDsgONfFO3heuMFcEIj 9f1WwE/XK4I+PPJWi/l+pA5gFojNjwCU30nMNmtyPPWsQ8jNS1HdLtCGC/7ndQugN/Vm EFNRTowK+hc7NcTlJEreyaPzgWo3IZKP+3gLKXhJIG2/m1zHrMMIurjtsUqvdsNhZsjw ceBmltQRdepiCeUjj59GqBG2ydDTu2aS15Sqf/eTqMBDgWQWw75dq4JTa0C1dWDGJ2dG TxEg== Received: by 10.204.155.139 with SMTP id s11mr5615666bkw.106.1341164944717; Sun, 01 Jul 2012 10:49:04 -0700 (PDT) Received: from [10.36.177.169] (089144192232.atnat0001.highway.a1.net. [89.144.192.232]) by mx.google.com with ESMTPS id ha10sm5786103bkc.3.2012.07.01.10.49.03 (version=SSLv3 cipher=OTHER); Sun, 01 Jul 2012 10:49:04 -0700 (PDT) From: Bernhard =?ISO-8859-1?Q?Fr=F6hlich?= To: Fernando =?ISO-8859-1?Q?Apestegu=ED?= , freebsd-ports@freebsd.org X-Mailer: Modest 3.90.7 References: In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-ID: <1341164677.10569.1.camel@Nokia-N900-42-11> Date: Sun, 01 Jul 2012 19:44:38 +0200 Message-Id: <1341164678.10569.2.camel@Nokia-N900-42-11> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Gm-Message-State: ALoCoQk8z4ycDLHxUq51AWWB/0kfki8p2KKs/uZ/3vH5w4b3ER43Xs+ReHIiyu380r/JoD78/Isk Cc: Subject: Re: [new-port] JDownloader X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Bernhard =?ISO-8859-1?Q?Fr=F6hlich?= List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Jul 2012 17:49:12 -0000 On So.,  1. Jul. 2012 19:32:58 CEST, Fernando Apesteguía wrote: > Hi all, > > I have a preliminary version of a port for JDownloader[1] since it > seems to be a wanted port[2] > > Here is the Makefile: > > ----------------------------------------------------------------------- > # New ports collection makefile for:    jdownloader > # Date created:                                      Sun Jul 1 2012 > # Whom:                    Fernando Apesteguia > # > # $FreeBSD$ > > PORTNAME=    jdownloader > PORTVERSION=    1.0 > CATEGORIES=    java ftp > MASTER_SITES=    http://212.117.163.148/ > DISTNAME=    jd.sh > EXTRACT_SUFX= > > MAINTAINER=    fernando.apesteguia@gmail.com > COMMENT=    Download management for one-click-hosters > > RUN_DEPENDS=    ${LOCALBASE}/bin/java:${PORTSDIR}/java/diablo-jdk16 > RUN_DEPENDS+=    ${LOCALBASE}/bin/wget:${PORTSDIR}/ftp/wget > > USE_JAVA=    yes > JAVA_VERSION=    1.6+ > NO_BUILD=    yes > > WRKSRC=        ${WRKDIR} > > do-extract: >     @${MKDIR} ${WRKDIR} >     @${CP} ${DISTDIR}/jd.sh ${WRKSRC} > > do-install: >     @${MKDIR} ${PREFIX}/${PORTNAME} >     @${INSTALL_SCRIPT} ${WRKSRC}/jd.sh ${PREFIX}/bin > > post-install: >     @${ECHO_MSG} "" >     @${ECHO_MSG} > "*************************************************************************" >     @${ECHO_MSG} JDownloader will update itself to the latest version when > it runs for the    @${ECHO_MSG} first time. Please run > ${LOCALBASE}/bin/jd.sh    @${ECHO_MSG} to complete the installation >     @${ECHO_MSG} > "*************************************************************************" >     @${ECHO_MSG} ""    @${CAT} ${PKGMESSAGE} > > .include > ----------------------------------------------------------------------- > > The port just needs a simple patch file (patch-jd.sh): > > ----------------------------------------------------------------------- > --- jd.sh.orig    2012-07-01 14:23:07.000000000 +0200 > +++ jd.sh    2012-07-01 14:24:15.000000000 +0200 > @@ -1,4 +1,4 @@ > -#!/bin/bash > +#!/bin/sh >  #JD Installer/Starter Version 0.2 >  #by Jiaz(JD-Team), jiaz@jdownloader.org >  #You need at least: > ----------------------------------------------------------------------- > > The jd.sh runs fine with sh(1) so there is no need for a new run > dependency for bash(1). > > The port installs one single file (jd.sh). This script when executed, > checks for the presence of the JDownloader jar files under the ~/.jd > directory. If they don't exist it starts the uploader application and > downloads the latest files. If the files were already present, it > launches the installation and if the installation is already present, > it launches the program. > Uninstalling the port uninstalls the jd.sh file but _not_ the actual > application that might be installed by the users in their respective > home directories. Taking into account that JDownloader can be > installed anyway just by downloading the source I don't suppose this > is a concern. Since the program can act as a server (it installs a > plugin for remote controlling the application similarly to what > transmission torrent does), it shows a message after the installation. > > I haven't submitted a PR yet, so any suggestions are welcomed. > > Thanks in advance. > > [1] http://jdownloader.org/ > [2] http://wiki.freebsd.org/WantedPorts Is there a reason why you explicitly add diablo-jdk16 as runtime dependency? The use_java stuff should be sufficient. Why have you decided to download and install the jar files on first run of the shellscript? That doesn't sound like a good idea to me because it breaks proper updates, deinstall and creates useless binary packages.