Date: Sun, 29 Jun 2008 11:22:07 +0000 From: Jens Rehsack <rehsack@web.de> To: Joe Marcus Clarke <marcus@marcuscom.com> Cc: FreeBSD GNOME Users <gnome@freebsd.org>, delphij@freebsd.org Subject: Re: ports/124115: net/openldap24-server: Auto-Detect OpenLDAP version and modify knobs according to common names Message-ID: <4867705F.3040408@web.de> In-Reply-To: <1214677236.86194.7.camel@shumai.marcuscom.com> References: <485E6E98.9000106@web.de> <1214677236.86194.7.camel@shumai.marcuscom.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Joe Marcus Clarke wrote:
> On Sun, 2008-06-22 at 15:24 +0000, Jens Rehsack wrote:
>> Hi,
>>
>> I tried a little around with the submitted patch and detected 2 issues:
>> 1) I had a typo in line 37 of bsd.ldap.mk
>> -DEFAULT_OPENLDPAP_VER?= 23
>> +DEFAULT_OPENLDAP_VER?= 23
>> It's quite easy to fix it ;)
>>
>> 2) A port (security/seahorse) checks in line 72 for ${WANT_OPENLDAP_VER},
>> which is deprecated. By the way - it doesn't want to check for
>> WANT_OPENLDAP_VER, it wants to check for ${OPENLDAP_VER}.
>> Doing this would require to split the "code" in bsd.ldap.mk into a
>> pre- and post-part, not handle everything in the post-part.
>>
>> What do you think?
>
> I've been away for a week and a half. Has anything come of this?
Welcome back. Seems, that there're some more people are away ;-)
> I have no objection to making seahorse more flexible in terms of LDAP
> support if the underlying code supports it.
But it is in the moment. The question is: how to deal with it? The
provided patch would be able to force openldap-24, but that may
conflict when openldap-23 is installed ...
> Joe
/Jens
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4867705F.3040408>