From owner-cvs-all Mon Oct 29 8:30:29 2001 Delivered-To: cvs-all@freebsd.org Received: from iguana.aciri.org (iguana.aciri.org [192.150.187.36]) by hub.freebsd.org (Postfix) with ESMTP id DA46737B407; Mon, 29 Oct 2001 08:30:20 -0800 (PST) Received: (from rizzo@localhost) by iguana.aciri.org (8.11.3/8.11.1) id f9TGQi801169; Mon, 29 Oct 2001 08:26:44 -0800 (PST) (envelope-from rizzo) Date: Mon, 29 Oct 2001 08:26:44 -0800 From: Luigi Rizzo To: Bruce Evans Cc: "Andrew R. Reiter" , Josef Karthauser , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: ipfw.c -- (was: cvs commit: src/sys/netinet ip_fw.h) Message-ID: <20011029082644.E96115@iguana.aciri.org> References: <20011029000216.A95875@iguana.aciri.org> <20011030030505.J12580-100000@delplex.bde.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20011030030505.J12580-100000@delplex.bde.org> User-Agent: Mutt/1.3.23i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, Oct 30, 2001 at 03:18:31AM +1100, Bruce Evans wrote: > > > In 4.4-RELEASE, style.9 says: > > > > > > Parts of a for loop may be left empty. Don't put declarations inside > > > blocks unless the routine is unusually complicated. > > > > oh yes, that was it. Well, I think that in the above section of style(9), > > the only reasonable interpretation of "the routine" is > > "the function in which the block is contained"; otherwise, you > > should assume that you are not supposed to use local variables > > in small functions! > > I think the only reasonable interpretation is that style(9) is poorly > worded. "blocks" means "inner blocks like the for loop immediately > following this paragraph". i questioned the interpretation of "routine", not "block". Variable declarations that are 500 lines away are only calling for subtle bugs to be introduced when modifying the code (and we have plenty of very large functions in the kernel). > > > In ipfw.c, there are a number of areas in which it does not make sense, in > > > terms of style.9, to declare a variable as local to the point where it's > > > no longer at the head of a function. Ie: > > > > I think this is exactly the case where it makes a lot of sense to > > declare vars locally to the block: the start of the function is > > far away, there is a bunch of small conditionals where each > > of them needs to use some temporary variable and those variables > > are meant to be used only within the block. > > The rule is certainly mean to disallow this. There are very few examples oh yes, i think it is really mean. But perhaps this is not what you meant :) cheers luigi To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message