Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 9 Dec 2008 19:44:53 +0000 (UTC)
From:      "Bjoern A. Zeeb" <bz@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r185807 - head/sys/net
Message-ID:  <200812091944.mB9JirJ6099892@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: bz
Date: Tue Dec  9 19:44:53 2008
New Revision: 185807
URL: http://svn.freebsd.org/changeset/base/185807

Log:
  Fix a bug introduced in r185747: rather than dereferencing an uninitialized
  *rt to something undefined, use the fibnum that came in as function argument.
  
  Found with:	Coverity Prevent(tm)
  CID:		4168

Modified:
  head/sys/net/route.c

Modified: head/sys/net/route.c
==============================================================================
--- head/sys/net/route.c	Tue Dec  9 19:36:50 2008	(r185806)
+++ head/sys/net/route.c	Tue Dec  9 19:44:53 2008	(r185807)
@@ -513,7 +513,7 @@ rtredirect_fib(struct sockaddr *dst,
 	struct rt_addrinfo info;
 	struct ifaddr *ifa;
 	struct radix_node_head *rnh =
-	    V_rt_tables[rt->rt_fibnum][dst->sa_family];
+	    V_rt_tables[fibnum][dst->sa_family];
 
 	/* verify the gateway is directly reachable */
 	if ((ifa = ifa_ifwithnet(gateway)) == NULL) {



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200812091944.mB9JirJ6099892>