Date: Thu, 24 May 2018 11:49:59 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Mark Millard <marklmi26-fbsd@yahoo.com>, FreeBSD Current <freebsd-current@freebsd.org> Cc: Cy.Schubert@cschubert.com, "O. Hartmann" <ohartmann@walstatt.org> Subject: Re: Another recent WITH_META_MODE= gotcha ": handling svn commit: r334008 - head/bin/sh Message-ID: <0f2dd2ac-009a-4298-1007-2e4a7766b546@FreeBSD.org> In-Reply-To: <2E8F4907-F2AD-4EAD-A78F-E3236E516C8B@yahoo.com> References: <2E8F4907-F2AD-4EAD-A78F-E3236E516C8B@yahoo.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--vy9WVSTv6BtQPvM2Zvg1ni8BO74Hqqmxl
Content-Type: multipart/mixed; boundary="95OKvJKNoQ8TvcwuMENU8NEfDPOAW9JA5";
protected-headers="v1"
From: Bryan Drewery <bdrewery@FreeBSD.org>
To: Mark Millard <marklmi26-fbsd@yahoo.com>,
FreeBSD Current <freebsd-current@freebsd.org>
Cc: Cy.Schubert@cschubert.com, "O. Hartmann" <ohartmann@walstatt.org>
Message-ID: <0f2dd2ac-009a-4298-1007-2e4a7766b546@FreeBSD.org>
Subject: Re: Another recent WITH_META_MODE= gotcha ": handling svn commit:
r334008 - head/bin/sh
References: <2E8F4907-F2AD-4EAD-A78F-E3236E516C8B@yahoo.com>
In-Reply-To: <2E8F4907-F2AD-4EAD-A78F-E3236E516C8B@yahoo.com>
--95OKvJKNoQ8TvcwuMENU8NEfDPOAW9JA5
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
On 5/21/2018 10:17 PM, Mark Millard wrote:
> Attempting to build head -r334014 from -r333947 includes the code from =
-r334008,
> and for which I get:
>=20
> --- parser.o ---
> /usr/src/bin/sh/parser.c:1440:9: error: use of undeclared identifier 'C=
QNL'
> case CQNL:
> ^
> 1 error generated.
>=20
> for what was added in -r334008.
>=20
> # grep -r CQNL /usr/src/* | more
> /usr/src/bin/sh/mksyntax.c: { "CQNL", "newline character in q=
uotes" },
> /usr/src/bin/sh/mksyntax.c: add("\n", "CQNL");
> /usr/src/bin/sh/mksyntax.c: add("\n", "CQNL");
> /usr/src/bin/sh/mksyntax.c: add("\n", "CQNL");
> /usr/src/bin/sh/parser.c: case CQNL:
> /usr/src/contrib/libarchive/libarchive/test/test_read_format_rar_binary=
_data.rar.uu:M+M7)?9;.A%CQNL-+4::&_UJQ*P"PPW:>)I5*8)7^>6(\]!Q"^9YCE>>`9OG=
8
>=20
> Apparently this is something WITH_META_MODE=3D does not deal with.
> Rebuilding after:
>=20
> rm -fr /usr/obj/amd64_clang/*
>=20
> (here I normally have the build materials) built fine.
>=20
> (The "Making top.local.h from /usr/src/contrib/top/top.local.hs"
> change to no longer have top.local.h or top.local.hs was another
> example: for a while top.local.h was still referenced and old ones
> would still be used if present.)
>=20
It was a bug with the rescue build with dependency handling. I've fixed
it in r334177.
--=20
Regards,
Bryan Drewery
--95OKvJKNoQ8TvcwuMENU8NEfDPOAW9JA5--
--vy9WVSTv6BtQPvM2Zvg1ni8BO74Hqqmxl
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBAgAGBQJbBwlYAAoJEDXXcbtuRpfPlqIIAIIT4X3VyUIQ/FfHXOPuEj/5
S3GJrkl49uQrpz6/zFxWzKwwv142/zku3NVilXcQfExEgZjM3FXTbmgbSpJvslbu
RdVjgzeAL+q5VPzdgqxkbbunMrWHumRqJWm9MYm3YPVdr72H+8HPyphfheC9UZ25
P8sO4j5o63m4LL5632k2hMatcLCgcyI5M3Kht76BtyGEYV+Z/lDHLs9agAxgcYf6
lPa8OWAwirAc6i7qBBwdSm/MIK3mKuJLEuxHf0WUDzVJEoevZ+9ymoY+DRv4qJCg
e+J09rkDqloCAnVKHeHmJucm76ts2sSFiDupgnqTjf5YA/1x2WDNAOCfwmIMb84=
=BC6L
-----END PGP SIGNATURE-----
--vy9WVSTv6BtQPvM2Zvg1ni8BO74Hqqmxl--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0f2dd2ac-009a-4298-1007-2e4a7766b546>