Date: Thu, 16 Nov 2000 03:40:03 -0800 (PST) From: Akio Morita <amorita@meadow.scphys.kyoto-u.ac.jp> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/22886: savecore dumps core at boot Message-ID: <200011161140.DAA49175@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/22886; it has been noted by GNATS. From: Akio Morita <amorita@meadow.scphys.kyoto-u.ac.jp> To: freebsd-gnats-submit@FreeBSD.org, olgeni@uli.it Cc: Akio Morita <amorita@meadow.scphys.kyoto-u.ac.jp> Subject: Re: bin/22886: savecore dumps core at boot Date: 16 Nov 2000 20:33:56 +0900 I found the reason of savecore's core dump problem(PR bin/22886). [Reason] See compile log in src/sbin/savecore. `ld' reports the symbol conflict `dirname'. In savecore.c, dirname symbol is local pointer of char. In libc/gen/dirname.c, dirname symbol is function. --- Log misao% make cc -O -pipe -I/usr/SRC/src/sbin/savecore/../../usr.bin/compress -c /usr/SRC/src/sbin/savecore/savecore.c cc -O -pipe -I/usr/SRC/src/sbin/savecore/../../usr.bin/compress -c /usr/SRC/src/sbin/savecore/../../usr.bin/compress/zopen.c cc -O -pipe -I/usr/SRC/src/sbin/savecore/../../usr.bin/compress -static -o savecore savecore.o zopen.o /usr/libexec/elf/ld: Warning: size of symbol `dirname' changed from 4 to 206 in dirname.o /usr/libexec/elf/ld: Warning: type of symbol `dirname' changed from 1 to 2 in dirname.o gzip -cn /usr/SRC/src/sbin/savecore/savecore.8 > savecore.8.gz --- Log [Quick Hack] Apply below patch to src/sbin/savecore/savecore.c. --- patch diff -d -u -r1.28.2.3 savecore.c --- savecore.c 2000/07/04 01:17:47 1.28.2.3 +++ savecore.c 2000/11/16 11:12:25 @@ -108,7 +108,7 @@ int dumpsize; /* amount of memory dumped */ char *kernel; -char *dirname; /* directory to save dumps in */ +static char *dirname; /* directory to save dumps in */ char *ddname; /* name of dump device */ dev_t dumpdev; /* dump device */ int dumpfd; /* read/write descriptor on char dev */ --- patch -- Akio Morita To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200011161140.DAA49175>