Date: Sun, 08 Aug 1999 18:17:18 -0600 From: Warner Losh <imp@village.org> To: mobile@FreeBSD.ORG Cc: freebsd-bugs@FreeBSD.ORG, sanpei@sanpei.org, iwasaki@jp.freebsd.org Subject: Re: [APM] kernel panic with apm command(Sotec WinBookPro). Message-ID: <199908090017.SAA02508@harmony.village.org> In-Reply-To: Your message of "Mon, 09 Aug 1999 01:46:12 %2B0900." <199908081642.BAA01817@tasogare.imasy.or.jp> References: <199908081642.BAA01817@tasogare.imasy.or.jp> <199908081506.AAA18497@lavender.yy.cs.keio.ac.jp>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <199908081642.BAA01817@tasogare.imasy.or.jp> Mitsuru IWASAKI writes:
: Anyone review my patch for this?
I've been running your patch for a while now. I don't have an old APM
BIOS that causes problems...
The patch looks good to me, except this part
: + if ((ret = apm_bioscall())) {
: + if (ret == -1) {
: + error = ENOSYS;
which should return be EINVAL. ENOSYS is returned only when the
system call itself isn't implemented. Since ioctl is implemented on
FreeBSD, returning it would be inappropriate.
Warner
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199908090017.SAA02508>