From owner-freebsd-current@FreeBSD.ORG Mon Jun 22 09:25:23 2015 Return-Path: Delivered-To: freebsd-current@nevdull.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2D3E4AFA for ; Mon, 22 Jun 2015 09:25:23 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from hub.freebsd.org (hub.freebsd.org [8.8.178.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "hub.freebsd.org", Issuer "hub.freebsd.org" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 0E0BA7F6 for ; Mon, 22 Jun 2015 09:25:23 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: by hub.freebsd.org (Postfix) id 00455AF9; Mon, 22 Jun 2015 09:25:23 +0000 (UTC) Delivered-To: current@nevdull.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id F3925AF8 for ; Mon, 22 Jun 2015 09:25:22 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 7EEAF7F3; Mon, 22 Jun 2015 09:25:21 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id t5M9PJtm059379 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 22 Jun 2015 12:25:19 +0300 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id t5M9PJIo059378; Mon, 22 Jun 2015 12:25:19 +0300 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Mon, 22 Jun 2015 12:25:18 +0300 From: Gleb Smirnoff To: Kevin Lo Cc: current@FreeBSD.org, adrian@FreeBSD.org Subject: Re: converted urtw(4) Was: [Testers needed!] WiFi drivers changes Message-ID: <20150622092518.GF73119@glebius.int.ru> References: <20150616163436.GP73119@glebius.int.ru> <20150617082855.GT73119@glebius.int.ru> <20150618081655.GA44125@ns.kevlo.org> <20150618104030.GK73119@glebius.int.ru> <20150622015123.GA56922@ns.kevlo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150622015123.GA56922@ns.kevlo.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jun 2015 09:25:23 -0000 On Mon, Jun 22, 2015 at 09:51:23AM +0800, Kevin Lo wrote: K> Thank you Gleb. urtw(4) works fine on amd64. Thanks. K> One minor problem, I got an compiler error and this diff below fixes it. K> K> --- D2655.diff.orig 2015-06-22 09:45:48.836385086 +0800 K> +++ D2655.diff 2015-06-22 09:47:56.121431950 +0800 K> @@ -10421,14 +10421,6 @@ K> struct urtw_vap *uvp = URTW_VAP(vap); K> struct ieee80211_node *ni; K> usb_error_t error = 0; K> -@@ -1905,7 +1858,6 @@ K> - default: K> - break; K> - } K> --fail: K> - URTW_UNLOCK(sc); K> - IEEE80211_LOCK(ic); K> - return (uvp->newstate(vap, nstate, arg)); K> @@ -1915,12 +1867,11 @@ K> urtw_watchdog(void *arg) K> { This patch is unclear to me. Can you please send a diff between my version and your version? Diff of diff drives me mad. -- Totus tuus, Glebius.