From owner-p4-projects@FreeBSD.ORG  Sun Dec 10 04:35:29 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 949CB16A412; Sun, 10 Dec 2006 04:35:29 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 6FF2916A403
	for <perforce@freebsd.org>; Sun, 10 Dec 2006 04:35:29 +0000 (UTC)
	(envelope-from imp@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 4B9A043C9E
	for <perforce@freebsd.org>; Sun, 10 Dec 2006 04:34:21 +0000 (GMT)
	(envelope-from imp@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kBA4ZTRf068171
	for <perforce@freebsd.org>; Sun, 10 Dec 2006 04:35:29 GMT
	(envelope-from imp@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kBA4ZSA2068168
	for perforce@freebsd.org; Sun, 10 Dec 2006 04:35:28 GMT
	(envelope-from imp@freebsd.org)
Date: Sun, 10 Dec 2006 04:35:28 GMT
Message-Id: <200612100435.kBA4ZSA2068168@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	imp@freebsd.org using -f
From: Warner Losh <imp@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 111365 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 10 Dec 2006 04:35:29 -0000

http://perforce.freebsd.org/chv.cgi?CH=111365

Change 111365 by imp@imp_lighthouse on 2006/12/10 04:35:08

	We don't need the check against phy == 0.  This appears to be
	a remant of a time when things were either borked, or a cut-n-paste
	job.  It is unclear, but also unnecessary.
	
	Remove DELAY.  It is also unnecessary.  This should help in network
	performance a little, since this steals about ~4 * 30us each
	second.

Affected files ...

.. //depot/projects/arm/src/sys/arm/at91/if_ate.c#63 edit

Differences ...

==== //depot/projects/arm/src/sys/arm/at91/if_ate.c#63 (text+ko) ====

@@ -988,11 +988,7 @@
 	 * XXX if we implement agressive power savings, then we need
 	 * XXX to make sure that the clock to the emac is on here
 	 */
-
-	if (phy != 0)
-		return (0xffff);
 	sc = device_get_softc(dev);
-	DELAY(1);	/* Hangs w/o this delay really 30.5us atm */
 	WR4(sc, ETH_MAN, ETH_MAN_REG_RD(phy, reg));
 	while ((RD4(sc, ETH_SR) & ETH_SR_IDLE) == 0)
 		continue;