Date: Thu, 22 Jun 2000 13:31:29 +0200 From: Stefan Esser <se@freebsd.org> To: Adrian Chadd <adrian@FreeBSD.ORG> Cc: mckusick@mckusick.com, freebsd-current@FreeBSD.ORG, Stefan Esser <se@freebsd.org> Subject: Re: cvs commit: src/sys/contrib/softupdates softdep.h ffs_softdep.c Message-ID: <20000622133129.A1816@StefanEsser.FreeBSD.org> In-Reply-To: <20000622115426.H29036@zoe.bastard.co.uk>; from adrian@FreeBSD.ORG on Thu, Jun 22, 2000 at 11:54:26AM %2B0200 References: <200006220029.RAA97417@freefall.freebsd.org> <20000621223309.G47446@argon.gryphonsoft.com> <86g0q6gw5x.wl@localhost.local.idaemons.org> <20000622080509.A4065@enterprise.sanyusan.se> <20000622103045.F29036@zoe.bastard.co.uk> <v04220804b5778cac1468@[10.0.1.6]> <20000622115426.H29036@zoe.bastard.co.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2000-06-22 11:54 +0200, Adrian Chadd <adrian@FreeBSD.ORG> wrote: > On Thu, Jun 22, 2000, Brad Knowles wrote: > > At 10:30 AM +0200 2000/6/22, Adrian Chadd wrote: > > > > > I like this. Would anyone object if this was brought over from NetBSD ? > > > > If you're asking for a vote, you've got mine. > > Hmm, Kirk has valid points for leaving a softupdates filesystem identified > by tunefs and not a mount option. I do remember the discussion that lead to the requirement to enable soft-updates with tunefs -n. But I do not remember, why the soft-updates state could not be just set in the local copy of the super-block and flushed to disk when the file system is marked dirty ? Just before a clean file system is to be mounted R/W, it is obviously safe to modify the soft-updates state. The file system must have been cleaned before, or the R/W mount will not be possible (extra logic can prevent the modification of the MNT_SOFTDEP bit if a mount of a non-clean partition is forced, in order to preserve the soft-updates state for the next fsck run). If the kernel was compiled without soft-updates, it may be the right thing to keep MNT_SOFTDEP cleared, to not mislead FSCK ... Did I miss something obvious ? Regards, STefan To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000622133129.A1816>