From owner-freebsd-ports@FreeBSD.ORG Fri Mar 28 20:47:58 2014 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 083303B4 for ; Fri, 28 Mar 2014 20:47:58 +0000 (UTC) Received: from spectrum.skysmurf.nl (spectrum.skysmurf.nl [82.95.125.145]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 803FE70 for ; Fri, 28 Mar 2014 20:47:57 +0000 (UTC) Received: from spectrum.skysmurf.nl (mail.skysmurf.nl [192.168.42.4] (may be forged)) by spectrum.skysmurf.nl (8.14.7/8.14.7) with SMTP id s2SKls5m005297; Fri, 28 Mar 2014 21:47:54 +0100 (CET) (envelope-from freebsd@skysmurf.nl) Received: by spectrum.skysmurf.nl (sSMTP sendmail emulation); Fri, 28 Mar 2014 21:47:54 +0100 Date: Fri, 28 Mar 2014 21:47:54 +0100 From: "A.J. 'Fonz' van Werven" To: Henry Hu Subject: Re: Mysterious patches Message-ID: <20140328204754.GA5208@spectrum.skysmurf.nl> References: <20140328201121.GA2505@spectrum.skysmurf.nl> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="huq684BweRXVnRxX" Content-Disposition: inline In-Reply-To: X-PGP-Key: http://www.skysmurf.nl/~fonz/fonz_pubkey.asc User-Agent: Mutt/1.5.23 (2014-03-12) Cc: "freebsd-ports@freebsd.org" X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Mar 2014 20:47:58 -0000 --huq684BweRXVnRxX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Henry Hu wrote: > They apply to src/raster-png.cxx and src/raster.cxx Note to self: look inside the actual patch files themselves, it says right there which files they apply to *oops*. However, this does leave me puzzled about the file names. If a patch applies to, say, src/foo/bar.c, shouldn't it be called files/patch-src__foo__bar.c? This is how it's described in the Porter's Handbook. Given a filename such as files/patch-png.cxx I would expect that patch to apply to a file ${WRKDIR}/png.cxx. What am I misunderstanding here? AvW --=20 I'm not completely useless, I can be used as a bad example. --huq684BweRXVnRxX Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQIcBAEBAgAGBQJTNd/6AAoJEAfP7gJTaCe8w6oQALX6RsIzewulZ54uPjrEqcNd 0KEpZQoNsJxY7Ng2RC3gWOCSx7wXTvC4/+KUdgqFrQ/p8CjZqWhBXem6zebqPQh0 sL3W/EQpauQYd8ytHdqXuMeQLoJwKFn3lYbkCb5OjA1eKNXhAscDE1jvQfidVp0n E//p32rzKYaC/Y6uNc0BbGoSw3s1kDKCFWnAIEsATjkcilh43arLXaUk0wnx1NIE 2NeCKlYLNBS+CkAIIvsNdnjKIr+5RkcSkep7SWNr3di3TGgeFdwsiheaJrfjuXmT gCBVP27MAw502GhWfQG5R4DuFuX7zfcfn+pNcA7qRV5vGn9+0EhSOOHGYTdO9MnB J7Q6VSulAGlrjnM11mKM/swh8KDndXXNFv5GMZErm5E36dYTFNKyzO1A7hbnJ1OB v9za35Rc4Z7hNyowG0j0mPxFzcHvHKrvg/unLkexfKauJgQ2BAiuiLDC2t8yc9f4 rHpLKwPLAZ6pC/3lmsoU9Unx77zMEUtHYznFss0aLsdaReiFGe/nzl6FKQ6Ky5p+ 6Q7L2FMG4+C+yYp5ao2sUwP9AOKQDmOjmOkv5vs5WWhXYCcqGoc7eyFrDwCA1JEB ctItm+Ot9g5kQ+1zd6JzKvAyZbcvkf3nUm1ydg7hC8DoN957MTJ+GJVVk8E6hOr8 CJ8EwtO5R71ZH0T3dDnv =SzTt -----END PGP SIGNATURE----- --huq684BweRXVnRxX--