From owner-freebsd-ports@FreeBSD.ORG Fri Mar 28 20:54:54 2014 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E05FC7A1 for ; Fri, 28 Mar 2014 20:54:54 +0000 (UTC) Received: from mail-oa0-x233.google.com (mail-oa0-x233.google.com [IPv6:2607:f8b0:4003:c02::233]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A7752147 for ; Fri, 28 Mar 2014 20:54:54 +0000 (UTC) Received: by mail-oa0-f51.google.com with SMTP id i4so6682525oah.24 for ; Fri, 28 Mar 2014 13:54:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=+x8DWLpymyoVEJ4bxkTXpu8nqrYb73z6fS/bo9g27e0=; b=VrkGtDvtACVjWgQ7qwk1RPUuxH+YamHiSwi0wLcFq0uNPN7ZVWQBrHmTri5jmejw8u fc4/doPGiAFaUM0gMbgFQYWtOQpba0Ur1AV0CKgqlALNpnAnmQ/126r0nlb6EBgCLDLv RKoU8PW0hO9T3nvN7bMjDfCb/YaFSaNqgK6+soHVNGy50/qCWAuKH9cZtLs0KSL1rmji QRkaVyH8GFX8h3nn+LTIHK8XlNljyXOmYZPoH2t1KlGbwxO/PcLUg8P7D9FDBdXuVqJR d3vLizEkjezb0xyzZc/gDH4PeJKm4eSCU/gvJoEBvTTlSrNQaewsk8LZHjVuyHsLkZvL ISUg== MIME-Version: 1.0 X-Received: by 10.183.3.102 with SMTP id bv6mr8646415obd.18.1396040093983; Fri, 28 Mar 2014 13:54:53 -0700 (PDT) Received: by 10.76.180.40 with HTTP; Fri, 28 Mar 2014 13:54:53 -0700 (PDT) In-Reply-To: <20140328204754.GA5208@spectrum.skysmurf.nl> References: <20140328201121.GA2505@spectrum.skysmurf.nl> <20140328204754.GA5208@spectrum.skysmurf.nl> Date: Fri, 28 Mar 2014 13:54:53 -0700 Message-ID: Subject: Re: Mysterious patches From: Freddie Cash To: "A.J. 'Fonz' van Werven" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.17 Cc: Henry Hu , "freebsd-ports@freebsd.org" X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Mar 2014 20:54:54 -0000 On Fri, Mar 28, 2014 at 1:47 PM, A.J. 'Fonz' van Werven wrote: > Henry Hu wrote: > > > They apply to src/raster-png.cxx and src/raster.cxx > > Note to self: look inside the actual patch files themselves, it says righ= t > there which files they apply to *oops*. > > However, this does leave me puzzled about the file names. If a patch > applies to, say, src/foo/bar.c, shouldn't it be called > files/patch-src__foo__bar.c? This is how it's described in the Porter's > Handbook. Given a filename such as files/patch-png.cxx I would expect tha= t > patch to apply to a file ${WRKDIR}/png.cxx. > > What am I misunderstanding here? > > =E2=80=8BPatch file naming conventions are just that: conventions. It's= not carved in stone and enforced in the tools. The patch program looks at the paths in the diff file to figure out which files need to be edited. The naming convention for patch files has changed over the years. Maybe this one is using an older convention? Or maybe it never followed one to begin with? Either way, it you take maintainership of the port, you can make it follow the current patch file naming convention. ;) =E2=80=8B --=20 Freddie Cash fjwcash@gmail.com