From owner-freebsd-gecko@freebsd.org Fri Jun 28 21:56:33 2019 Return-Path: Delivered-To: freebsd-gecko@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EBB0115CD0D8 for ; Fri, 28 Jun 2019 21:56:32 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 6722A8A630 for ; Fri, 28 Jun 2019 21:56:32 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 21E3615CD0D7; Fri, 28 Jun 2019 21:56:32 +0000 (UTC) Delivered-To: gecko@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1056715CD0D5 for ; Fri, 28 Jun 2019 21:56:32 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AAC208A62E; Fri, 28 Jun 2019 21:56:31 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1354) id 825D911271; Fri, 28 Jun 2019 21:56:31 +0000 (UTC) From: Jan Beich To: Steve Wills Cc: gecko@FreeBSD.org Subject: Re: Firefox and GTK2 References: <7536c5cf-f8a0-fe5c-661f-b7909b9d57aa@FreeBSD.org> <491275b9-47ef-58b4-ab0c-bdaf1bed13b4@FreeBSD.org> <5d74ebf9-49cd-04bc-d6b5-aa156491f29f@FreeBSD.org> Date: Fri, 28 Jun 2019 23:56:27 +0200 In-Reply-To: <5d74ebf9-49cd-04bc-d6b5-aa156491f29f@FreeBSD.org> (Steve Wills's message of "Fri, 28 Jun 2019 16:15:40 -0400") Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: AAC208A62E X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.92 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_SHORT(-0.92)[-0.925,0]; ASN(0.00)[asn:11403, ipnet:96.47.64.0/20, country:US]; NEURAL_HAM_MEDIUM(-0.99)[-0.992,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: freebsd-gecko@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gecko Rendering Engine issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Jun 2019 21:56:33 -0000 Steve Wills writes: > Hi, > > On 6/28/19 3:03 PM, Jan Beich wrote: >> Steve Wills writes: >> > [snip] >> >> www/firefox only directly loads libcanberra.so.0. > > Right, so we can have libcanberra use gtk2 or gtk3. > >> What actually depends >> on -gtk3 slave? For one, x11-toolkits/gtk30 dropped it since 3.18.0. >> >> https://searchfox.org/mozilla-release/rev/be9f154873f1/widget/gtk/nsSound.cpp#159 >> https://gitlab.gnome.org/GNOME/gtk/commit/7439a7efda25 > > It's not about gtk using libcanberra, it's about which gtk is used by > libcanberra. How does libcanberra decide which gtk to use? > >> $ strings /usr/local/lib/libcanberra.so | fgrep gtk3 >> $ strings /usr/local/lib/libcanberra-gtk.so | fgrep gtk3 >> > > Those two files are from the package of libcanberra that depends on > gtk2, so I wouldn't expect them to depend on gtk3. That's the point. I couldn't find where libcanberra depends on gtk3. It's probably Gtk that calls into libcanberra. If so then every gtk30 consumer that depends on libcanberra also needs libcanberra-gtk3. $ strings /usr/local/lib/gtk-2.0/modules/libcanberra-gtk-module.so | fgrep libcanberra libcanberra.so.0 libcanberra-gtk.so.0 libcanberra-gtk-module.so $ strings /usr/local/lib/gtk-3.0/modules/libcanberra-gtk-module.so | fgrep libcanberra libcanberra.so.0 libcanberra-gtk3.so.0 libcanberra-gtk3-module.so >> GTK3 is still optional in www/seamonkey and not supported in www/palemoon. > > Maybe the libcanberra dep could be moved out of bsd.gecko.mk and into > the ports? Right. To Mk/Uses/gnome.mk where USE_GNOME=canberra can decide whether to pull -gtk3 slave or not.