From owner-freebsd-stable@freebsd.org Wed Oct 5 21:34:40 2016 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D9ECEAF74AF for ; Wed, 5 Oct 2016 21:34:40 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citapm.icyb.net.ua (citapm.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 3CE65CC3 for ; Wed, 5 Oct 2016 21:34:39 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citapm.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id AAA05571; Thu, 06 Oct 2016 00:34:39 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1brtpm-0008g2-R5; Thu, 06 Oct 2016 00:34:38 +0300 Subject: Re: aibs(4) / atk0110 support for newer systems To: Torfinn Ingolfsen , freebsd-stable@FreeBSD.org References: <86cf8380-ac6f-55f0-f0f8-16000d7f04b2@FreeBSD.org> <20160930145704.4dbc9d90011154b38493964e@getmail.no> <7d498084-ec05-d4c9-5f49-6aef32495caf@FreeBSD.org> <20160930205928.77d7e74f7bd1a35fcf1aa50a@getmail.no> <7a868c22-e0bd-f677-e4ad-2bdf6f3605d0@FreeBSD.org> <20161003201511.7258687453f12c44a46a361a@getmail.no> <20161005143723.4273657959160b67637a5adf@getmail.no> <4c431c8a-7c8c-4336-b948-6e9ae882c0fc@FreeBSD.org> <20161005222831.e674c3a134266c2e1edc523e@getmail.no> From: Andriy Gapon Message-ID: <13fde509-5081-3e44-6729-352f814585af@FreeBSD.org> Date: Thu, 6 Oct 2016 00:34:03 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161005222831.e674c3a134266c2e1edc523e@getmail.no> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Oct 2016 21:34:40 -0000 On 05/10/2016 23:28, Torfinn Ingolfsen wrote: > On Wed, 5 Oct 2016 16:09:40 +0300 > Andriy Gapon wrote: > >> >> Seems like this is a clang vs gcc issue as I didn't get warnings here. >> Could you please simply add initialization to those variables in aibs_attach_ggrp()? >> E.g.: >> s_idx = NULL; >> so = NULL; > > I ended up adding > s_idx = NULL; > so = NULL; > name = NULL; > > to aibs_attach_ggrp(), that made the module compile. Okay, thank for letting me know. > Unfortunately, my machines panics as soon as this module is loaded: Not good... > root@kg-core1# cat /var/crash/info.0 > Dump header from device /dev/ada0p3 > Architecture: amd64 > Architecture Version: 2 > Dump Length: 1466040320B (1398 MB) > Blocksize: 512 > Dumptime: Wed Oct 5 21:48:42 2016 > Hostname: kg-core1.kg4.no > Magic: FreeBSD Kernel Dump > Version String: FreeBSD 9.3-STABLE #3 r304838: Fri Aug 26 12:11:25 CEST 2016 > root@kg-core1.kg4.no:/usr/obj/usr/src/sys/GENERIC > Panic String: page fault > Dump Parity: 1914870814 > Bounds: 0 > Dump Status: good > > core.txt.0 attached > HTH Seems like the module got built without debug symbols. Please try make KERNBUILDDIR=/usr/obj/... -- Andriy Gapon