From owner-freebsd-threads@FreeBSD.ORG Tue Aug 5 14:12:20 2003 Return-Path: Delivered-To: freebsd-threads@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 85F9337B401 for ; Tue, 5 Aug 2003 14:12:20 -0700 (PDT) Received: from mail.pcnet.com (mail.pcnet.com [204.213.232.4]) by mx1.FreeBSD.org (Postfix) with ESMTP id E26C643F93 for ; Tue, 5 Aug 2003 14:12:19 -0700 (PDT) (envelope-from eischen@vigrid.com) Received: from mail.pcnet.com (mail.pcnet.com [204.213.232.4]) by mail.pcnet.com (8.12.8/8.12.1) with ESMTP id h75LCInj011940; Tue, 5 Aug 2003 17:12:19 -0400 (EDT) Date: Tue, 5 Aug 2003 17:12:18 -0400 (EDT) From: Daniel Eischen X-Sender: eischen@pcnet5.pcnet.com To: Marcel Moolenaar In-Reply-To: <20030805210011.GB879@athlon.pn.xcllnt.net> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: threads@freebsd.org Subject: Re: Good news: KSE on ia64 is starting to work X-BeenThere: freebsd-threads@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: deischen@freebsd.org List-Id: Threading on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Aug 2003 21:12:20 -0000 On Tue, 5 Aug 2003, Marcel Moolenaar wrote: > On Tue, Aug 05, 2003 at 04:43:00PM -0400, Daniel Eischen wrote: > > > In struct ia64_tp we define tp_tls as an array of char. If we > > > define it as an array of long double we automaticly have 16-byte > > > alignment of the static TLS, struct ia64_tp, struct tcb and > > > struct kcb. Allocating the TCB will then automaticly ensure that > > > the static TLS is properly aligned. I'm currently testing with > > > the following (re)definition of struct ia64_tp: > > > > > > struct ia64_tp { > > > struct tdv *tp_tdv; /* dynamic TLS */ > > > struct tcb *tp_self; > > > long double tp_tls[0]; /* static TLS */ > > > }; > > > > Sure; that was merely a placeholder so one (you) could replace > > it with whatever is needed. I assume this (static TLS) will > > have some predetermined size... > > It's a runtime constant yes. We'll know the size of the static TLS > when we initialize libkse/libpthread and TLS support has been added. Do we need an additional parameter to _tcb_ctor() to specify the static TLS size? > I expect that kcb_faketcb doesn't need any TLS, because it's not > used for running user code, just an internal "doohicky", right? Right; the UTS needs some way to get to the current KSE. > BTW: Feel free to commit your patch at your earliest convenience > (with or without the change described above). I see a slight > regression after applying the patch, but much rather see it > committed than having to work with a large patch... Hmm, ok. -- Dan Eischen