Date: Wed, 13 Dec 2006 01:03:26 +0800 From: Rong-En Fan <rafan@infor.org> To: Max Laier <max@love2party.net> Cc: ports@freebsd.org, sumikawa@freebsd.org, Scot Hetzel <swhetzel@gmail.com>, Rong-En Fan <rafan@freebsd.org>, freebsd-ports@freebsd.org Subject: Re: sysutils/xbattbar for !i386 Message-ID: <20061212170326.GQ68344@svm.csie.ntu.edu.tw> In-Reply-To: <200612121504.13271.max@love2party.net> References: <20061212064859.GA33414@svm.csie.ntu.edu.tw> <790a9fff0612120057j7ab3c6fdxb3761c7e6ef4cae6@mail.gmail.com> <20061212121035.GB33414@svm.csie.ntu.edu.tw> <200612121504.13271.max@love2party.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--0et/Au7PJwzVwd4K Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 12, 2006 at 03:04:05PM +0100, Max Laier wrote: > On Tuesday 12 December 2006 13:10, Rong-En Fan wrote: > > On Tue, Dec 12, 2006 at 02:57:12AM -0600, Scot Hetzel wrote: > > > On 12/12/06, Scot Hetzel <swhetzel@gmail.com> wrote: > > > >On 12/12/06, Rong-En Fan <rafan@freebsd.org> wrote: > > > >> Recently, I installed a FreeBSD/amd64 laptop. I found this port > > > >> uses apm (i386 only) interface to get battery information. The > > > >> patch below changes it to use sysctl(3). Thus, it is usable on > > > >> amd64. > > > >> > > > >> http://people.freebsd.org/~rafan/xbattbar.diff > > > >> > > > >> It works on my ThinkPad X60 (-CURRENT). If you are running this > > > >> port, please have a test. > > > > > > > >Works on my HP dv8135nr (-CURRENT) system. > > > > > > I have updated the patch so that it can be compiled for systems that > > > have either an APM or ACPI interface for battery status. > > > > > > The Makefile has been changed to always use the ACPI interface when > > > not being built on the i386 arch (i.e. amd64, ...). On the i386 arch > > > it defaults to ACPI, but can be changed via the options menu to use > > > APM. > > > > The way you handle OPTIONS is incorrect. See Porter's Handbook and/or > > http://lists.freebsd.org/pipermail/cvs-ports/2006-May/093088.html > > for details. > > > > As for APM/ACPI knob, I think APM is necessary on 4.x. Not sure > > about 5.x status. If acpi on 5.x is usable, I suggest we just > > use acpi and use apm on 4.x i386 only? >=20 > Can't you make this a runtime option on i386. If the ACPI sysctl is ther= e=20 > use it, if not fall back to APM. Also it seems to make sense to report= =20 Good suggestion. I updated my patch at=20 http://people.freebsd.org/~rafan/xbattbar.diff > this upstream instead of sticking it in patches. Of course. But it seems to me that this software stops development since few years ago. I will contact the author anyway. Thanks, Rong-En Fan --0et/Au7PJwzVwd4K Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFFfuDd144QkYb9jGgRAvHOAJ4v8NlR/rOj7GqPomvZg598y0B8NwCfXWve SJc10Jq9DF2H8e+xNLr2pBI= =2q3W -----END PGP SIGNATURE----- --0et/Au7PJwzVwd4K--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20061212170326.GQ68344>