From owner-freebsd-net@FreeBSD.ORG Tue Nov 9 20:57:06 2004 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 57C7816A4CE; Tue, 9 Nov 2004 20:57:06 +0000 (GMT) Received: from relay.bestcom.ru (relay.bestcom.ru [217.72.144.5]) by mx1.FreeBSD.org (Postfix) with ESMTP id 714C343D48; Tue, 9 Nov 2004 20:57:05 +0000 (GMT) (envelope-from glebius@freebsd.org) Received: from cell.sick.ru (root@cell.sick.ru [217.72.144.68]) by relay.bestcom.ru (8.13.1/8.12.9) with ESMTP id iA9Kv42V079713 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Tue, 9 Nov 2004 23:57:04 +0300 (MSK) (envelope-from glebius@freebsd.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.12.11/8.12.8) with ESMTP id iA9Kv3Xd048705 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 9 Nov 2004 23:57:03 +0300 (MSK) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.sick.ru (8.12.11/8.12.11/Submit) id iA9Kv3eI048704; Tue, 9 Nov 2004 23:57:03 +0300 (MSK) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@freebsd.org using -f Date: Tue, 9 Nov 2004 23:57:03 +0300 From: Gleb Smirnoff To: green@freebsd.org Message-ID: <20041109205703.GB48632@cell.sick.ru> References: <20041109082903.GA42446@cell.sick.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20041109082903.GA42446@cell.sick.ru> User-Agent: Mutt/1.5.6i X-Virus-Scanned: clamd / ClamAV version devel-20041013, clamav-milter version 0.75l on 127.0.0.1 X-Virus-Status: Clean cc: net@freebsd.org Subject: Re: ng_ksocket as divert socket is broken X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Nov 2004 20:57:06 -0000 Brian, doing a serie of tests I have found that this commit has introduced regression described below: http://lists.freebsd.org/pipermail/cvs-src/2004-October/032888.html Now I'm working on this, but I'd be glad if you join. On Tue, Nov 09, 2004 at 11:29:03AM +0300, Gleb Smirnoff wrote: T> I've recently noticed a regression between RELENG_5 and CURRENT. T> In CURRENT ng_ksocket is unable to work as divert socket. Since T> you have touched divert code recently I'm asking you. Today I'm T> going to dig deeply there, but probably you can give some ideas T> without investigation. T> T> A test for this functionality looks like this: T> T> /usr/sbin/ngctl -f- <<-SEQ T> mkpeer echo dummy dummy T> name .:dummy echo_div T> mkpeer echo_div: ksocket echo inet/raw/divert T> name echo_div:echo div_sock T> rmhook dummy T> msg div_sock: bind inet/0.0.0.0:8888 T> SEQ T> T> ipfw add 1000 divert 8888 all from any to any via fxp0 T> T> And packets should flow thru fxp0 in both directions. Do not T> try lo0, there are some problems in there. T> T> You also need this patch (going to commit it soon), if you are T> running INVARIANTS: T> T> --- ip_divert.c 25 Oct 2004 20:02:34 -0000 1.106 T> +++ ip_divert.c 9 Nov 2004 08:27:24 -0000 T> @@ -277,7 +277,7 @@ T> struct divert_tag *dt; T> int error = 0; T> T> - KASSERT(m->m_pkthdr.rcvif == NULL, ("rcvif not null")); T> + m->m_pkthdr.rcvif = NULL; T> T> if (control) T> m_freem(control); /* XXX */ T> -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE