From owner-freebsd-ports@FreeBSD.ORG Wed Jan 11 16:24:00 2012 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AED23106566B for ; Wed, 11 Jan 2012 16:24:00 +0000 (UTC) (envelope-from m.seaman@infracaninophile.co.uk) Received: from smtp.infracaninophile.co.uk (smtp6.infracaninophile.co.uk [IPv6:2001:8b0:151:1:3cd3:cd67:fafa:3d78]) by mx1.freebsd.org (Postfix) with ESMTP id 115108FC14 for ; Wed, 11 Jan 2012 16:23:59 +0000 (UTC) Received: from seedling.black-earth.co.uk (seedling.black-earth.co.uk [IPv6:2001:8b0:151:1:fa1e:dfff:feda:c0bb]) (authenticated bits=0) by smtp.infracaninophile.co.uk (8.14.5/8.14.5) with ESMTP id q0BGNuIF068404 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO) for ; Wed, 11 Jan 2012 16:23:56 GMT (envelope-from m.seaman@infracaninophile.co.uk) X-DKIM: OpenDKIM Filter v2.4.1 smtp.infracaninophile.co.uk q0BGNuIF068404 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=infracaninophile.co.uk; s=201001-infracaninophile; t=1326299036; bh=/c05zQyh5VXtUeHUmuqQah69fOeqfiI5w1dy4/iAY/Y=; h=Message-ID:Date:From:MIME-Version:To:Subject:References: In-Reply-To:Content-Type:Cc; b=GBZXqCzXmzIo4PY5z7tNLogvO1h+PZgDIua+QeG6fmY6QJUKZlCJoOsQY1mGUd1Ar 8w1urUekKZRCGJ4slcHze1CvVtZWxrV7t3hrpAZfak3qAmPf9xgbaenthAfp8APvgb BrX751gEUfkCY26oygrmgYThvICJJGva07PGQmP0= Message-ID: <4F0DB794.7000600@infracaninophile.co.uk> Date: Wed, 11 Jan 2012 16:23:48 +0000 From: Matthew Seaman User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0) Gecko/20111222 Thunderbird/9.0.1 MIME-Version: 1.0 To: freebsd-ports@freebsd.org References: <4F0446B7.4090703@herveybayaustralia.com.au> <20120104142757.1c77c347@ernst.jennejohn.org> <4F04E648.9090206@herveybayaustralia.com.au> <20120105121825.656677e4@ernst.jennejohn.org> <20120106221610.00005fbe@unknown> <20120108160316.00003d59@unknown> <4F0A8164.9090502@herveybayaustralia.com.au> <20120110221115.00007dc1@unknown> <4F0CDB5B.9030402@herveybayaustralia.com.au> In-Reply-To: X-Enigmail-Version: 1.3.4 OpenPGP: id=60AE908C Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigD7CE31D95C45E52DF18CE23D" X-Virus-Scanned: clamav-milter 0.97.3 at lucid-nonsense.infracaninophile.co.uk X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on lucid-nonsense.infracaninophile.co.uk Subject: Re: linux-f10-nss_ldap: my first port - be gentle :) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jan 2012 16:24:00 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigD7CE31D95C45E52DF18CE23D Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/01/2012 16:10, Eitan Adler wrote: >>> post-extract: >>> >> .if defined(WITH_PAM) >>> >> PLIST_FILES+=3Dlib/security/pam_ldap.so >>> >> >>> >> >>> >> .else >>> >> @if [ -f ${WRKDIR}/lib/security/pam_ldap.so ];= then \ >>> >> ${RM} ${WRKDIR}/lib/security/pam_ldap.so >>> >> ${DIRRM} ${WRKDIR}/lib/; >>> >> fi >> > >> > ^^^^^ >> > This is what's wrong. In port Makefiles, it's .if, .else, .endif no= t fi. > You need both: .endif and fi in this case (the 'fi' is part of the shel= l script) Also the shell script part needs to be backslashed, and statements separated by semi-colons, like so: @if [ -f ${WRKDIR}/lib/security/pam_ldap.so ]; then \ ${RM} ${WRKDIR}/lib/security/pam_ldap.so ; \ ${DIRRM} ${WRKDIR}/lib/ ; \ fi Looking back at the OP's previous posts, it's this backslashing thing which is missing: the (make) .if is properly closed with a .endif, which unfortunately got cropped in one of the replies upthread. Another point: its not usual to modify variables like PLIST_FILES or PORTDOCS as part of the post-extract target. Usually that's done earlier in the Makefile before any of the actual make targets. Cheers, Matthew --=20 Dr Matthew J Seaman MA, D.Phil. 7 Priory Courtyard Flat 3 PGP: http://www.infracaninophile.co.uk/pgpkey Ramsgate JID: matthew@infracaninophile.co.uk Kent, CT11 9PW --------------enigD7CE31D95C45E52DF18CE23D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.16 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk8Nt5sACgkQ8Mjk52CukIwJIgCeOmIV3Uo6as3sAbXmToO4J+T8 tGAAn15b/k2IVCx2rLYdZvUx+pHKsG1T =hlb2 -----END PGP SIGNATURE----- --------------enigD7CE31D95C45E52DF18CE23D--