Date: Fri, 5 Jun 1998 09:58:13 +1000 From: Bruce Evans <bde@zeta.org.au> To: dima@tejblum.dnttm.rssi.ru, peter@netplex.com.au Cc: asami@FreeBSD.ORG, committers@FreeBSD.ORG, jdp@polstra.com Subject: Re: cvs commit: src/sys/nfs nfs_vnops.c Message-ID: <199806042358.JAA30226@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
>I think, NFS may and should pretend that chflags(..., 0) succeed. No. The lower layers should pass errors up so that the highest layer can decide what to do. >Nobody >would notice any difference, anyway :-) Bug in wetware layer :-). >msdosfs do so since 1994 (rev. 1.11 >of msdosfs_vnops.c). (It returns EINVAL rather than EOPNOTSUPP, though. >I plan to change it.) EINVAL was reasonable. msdosfs_settattr() returns EINVAL for several other things that it doesn't really support. For chown/chgrp, this is even correct. It supports null changes, and other changes are invalid :-). Perhaps chflags() should be handled similarly. Setting the flags to 0 should just work. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199806042358.JAA30226>