Date: Sat, 5 Aug 2006 12:54:55 +0400 From: Andrey Chernov <ache@FreeBSD.ORG> To: G?bor K?vesd?n <gabor@FreeBSD.ORG> Cc: ports@FreeBSD.ORG, Edwin Groothuis <edwin@mavetju.org> Subject: Re: HEADS-UP: DESTDIR support committed to Mk/ Message-ID: <20060805085455.GA46190@nagual.pp.ru> In-Reply-To: <44D45B87.5060601@FreeBSD.org> References: <44D370E9.1080209@FreeBSD.org> <20060805070336.GA997@k7.mavetju> <44D45B87.5060601@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Aug 05, 2006 at 10:49:11AM +0200, G?bor K?vesd?n wrote:
> Edwin Groothuis wrote:
> >On Fri, Aug 04, 2006 at 06:08:09PM +0200, G?bor K?vesd?n wrote:
> >
> >>I am pleased to announce, that portmgr committed my patch for ports
> >>infrastructure DESTDIR support today. Note that this support is only for
> >>the infrastructure, ports may or may not respect the DESTDIR macro, so
> >>
> >
> >Having read the wiki, please let me ask a couple of questions to
> >make sure there is consensus on what needs to be done to make all
> >ports DESTDIR happy.
> >
> >- All ports Makefiles should be checked for installs into PREFIX,
> > and replaced by TARGETDIR (or DESTDIR/PREFIX)
> >
> Yes, TARGETDIR resolves to DESTDIR/PREFIX, which should be the final
> destination. In many ports we have a do-install or post-install target
> with something like:
>
> @${INSTALL_PROGRAM} ${WRKSRC}/foo ${PREFIX}/bin
>
> This is definitely not good, since it will install to ${PREFIX} even if
> you set DESTDIR, so this needs a s/${PREFIX}/${TARGETDIR}/.
It will be much better to not change that in almost in every port, but
change meaning of PREFIX instead:
PREFIX == DESTDIR/DESTPREFIX
--
http://ache.pp.ru/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060805085455.GA46190>