From owner-cvs-src@FreeBSD.ORG Thu Aug 28 06:24:17 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2EA5D16A4C0; Thu, 28 Aug 2003 06:24:17 -0700 (PDT) Received: from exc-1.cc.CyberCity.dk (esplanaden.cybercity.dk [212.242.40.114]) by mx1.FreeBSD.org (Postfix) with ESMTP id 009C443F75; Thu, 28 Aug 2003 06:24:15 -0700 (PDT) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk ([172.16.7.254]) by exc-1.cc.CyberCity.dk over TLS secured channel with Microsoft SMTPSVC(5.0.2195.6713); Thu, 28 Aug 2003 15:24:13 +0200 Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.9/8.12.9) with ESMTP id h7SDO7bf005536; Thu, 28 Aug 2003 15:24:07 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) To: Hidetoshi Shimokawa From: "Poul-Henning Kamp" In-Reply-To: Your message of "Thu, 28 Aug 2003 22:20:21 +0900." Date: Thu, 28 Aug 2003 15:24:07 +0200 Message-ID: <5535.1062077047@critter.freebsd.dk> X-OriginalArrivalTime: 28 Aug 2003 13:24:13.0497 (UTC) FILETIME=[AC38D290:01C36D67] cc: src-committers@FreeBSD.org cc: Hidetoshi Shimokawa cc: cvs-src@FreeBSD.org cc: John-Mark Gurney cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf majors X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Aug 2003 13:24:17 -0000 In message , Hidetoshi Shimokawa writes : >At Thu, 28 Aug 2003 15:02:23 +0200, >Poul-Henning Kamp wrote: >> >> In message , Hidetoshi Shimokawa writes >> : >> >> >> >WARNING: driver "foo" used unreserved major device number bar >> >> >> >> You should use automatic assignment of majors. >> > >> >Do you have any sample of console drivers converted to use MAJOR_AUTO? >> >> I don't really think that it matters that it is a console driver, >> why should it ? > >We call makedev() in cnprobe and we cannot call make_dev() before >SI_SUB_DRIVERS. This is my understanding why we have not converted >any console driver to use MAJOR_AUTO. Ohh, right, _that_ hack. Yes, in that case you need a static Major. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.