From owner-cvs-src@FreeBSD.ORG  Thu Feb 12 09:02:50 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 7061016A4CE; Thu, 12 Feb 2004 09:02:50 -0800 (PST)
Received: from mailout1.pacific.net.au (mailout1.pacific.net.au [61.8.0.84])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id E8BAB43D1D; Thu, 12 Feb 2004 09:02:49 -0800 (PST)
	(envelope-from bde@zeta.org.au)
Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au
	[61.8.0.86])i1CH2mLE027658;	Fri, 13 Feb 2004 04:02:48 +1100
Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246])
	i1CH2ki1019490;	Fri, 13 Feb 2004 04:02:47 +1100
Date: Fri, 13 Feb 2004 04:02:46 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Poul-Henning Kamp <phk@FreeBSD.org>
In-Reply-To: <20040120175334.W3279@gamplex.bde.org>
Message-ID: <20040213035557.M24031@gamplex.bde.org>
References: <200401192127.i0JLRBL3041817@repoman.freebsd.org>
 <20040120175334.W3279@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/alpha/alpha support.s src/sys/i386/i386   
 swtch.s src/sys/kern kern_shutdown.c src/sys/sys systm.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Feb 2004 17:02:50 -0000

On Tue, 20 Jan 2004, Bruce Evans wrote:

> On Mon, 19 Jan 2004, Poul-Henning Kamp wrote:
>
> > phk         2004/01/19 13:27:11 PST
> >
> >   FreeBSD src repository
> >
> >   Modified files:
> >     sys/alpha/alpha      support.s
> >     sys/i386/i386        swtch.s
> >     sys/kern             kern_shutdown.c
> >     sys/sys              systm.h
> >   Log:
> >   Add linenumber and source filename to panic(9) output.
>
> This was rejected in all reviews.  It gives less information than
> grepping the sources, at some cost (grep at least gives correct line
> numbers when the sources don't quite match the binary).
>
> Please back this out.

I'm still waiting for this to be backed out.

I just found yet another bug in it: it defeats simple regression checks.
Suppose you make some cosmetic changes that add a line before a panic.
This now changes the object file even when the file is compiled without
-g.

Bruce