Date: Mon, 26 Sep 2005 22:50:11 +0200 From: Andre Oppermann <andre@freebsd.org> To: Sam Leffler <sam@errno.com> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netipsec ipsec_mbuf.c Message-ID: <43385F03.B0BDA733@freebsd.org> References: <200509262035.j8QKZj04022444@repoman.freebsd.org> <43385C89.60009@errno.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Sam Leffler wrote: > > Andre Oppermann wrote: > > andre 2005-09-26 20:35:45 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/netipsec ipsec_mbuf.c > > Log: > > Replace custom mbuf writeability test with generic M_WRITABLE() test > > covering all edge cases too. > > I vaguely recall that M_WRITEABLE did exist when I wrote that code but > it did not do the right thing. I'm not sure why you needed to make this > change but beware of unexpected side effects. The test in question tries to determine whether to copy the mbuf to make to safe for modification. The old did not respect the M_RDONLY for example. M_WRITABLE() correctly tests for all cases. -- Andre
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?43385F03.B0BDA733>