From owner-cvs-all Tue Dec 17 0: 6:15 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1D76E37B401; Tue, 17 Dec 2002 00:06:14 -0800 (PST) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3BD2543ED1; Tue, 17 Dec 2002 00:06:13 -0800 (PST) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.6/8.12.6) with ESMTP id gBH85fk5015359; Tue, 17 Dec 2002 09:05:47 +0100 (CET) (envelope-from phk@critter.freebsd.dk) To: "M. Warner Losh" Cc: dillon@apollo.backplane.com, julian@elischer.org, nate@root.org, julian@FreeBSD.org, cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/i386 dump_machdep.c From: phk@FreeBSD.org In-Reply-To: Your message of "Mon, 16 Dec 2002 21:24:01 MST." <20021216.212401.38686246.imp@bsdimp.com> Date: Tue, 17 Dec 2002 09:05:41 +0100 Message-ID: <15358.1040112341@critter.freebsd.dk> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <20021216.212401.38686246.imp@bsdimp.com>, "M. Warner Losh" writes: >In message: <200212170108.gBH18V4r082434@apollo.backplane.com> > Matthew Dillon writes: >: Isn't it using off_t there? 64 bit offsets? > >daddr_t you mean? off_t is for file offsets, not for disklabel >sizes... GEOM operates on byte offsets in order to be able to accomodate non 2^n sector sizes (CD's for instance). Rather than hardcode the size as uint64_t, and rather than introduce yet a bloody typedef, I chose to use off_t for the offsets. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message