Date: Fri, 26 May 2000 15:52:35 +1000 From: Gregory Bond <gnb@itga.com.au> To: yab@astem.or.jp Cc: freebsd-bugs@FreeBSD.ORG Subject: Re: kern/18526: mx does not receive ethernet broadcast packet Message-ID: <200005260552.PAA20510@lightning.itga.com.au> In-Reply-To: Your message of Thu, 25 May 2000 03:20:03 -0700.
next in thread | raw e-mail | index | archive | help
> + if (t->mx_did == MX_DEVICEID_987x5) > + if (rev != MX_REVISION_98715AEC) > + t++; > + else if (rev >= MX_REVISION_98725) > + t++; Either I'm dense or this is not right (or at the very least, wildly redundant). if (rev != a) t++; else if (rev >= b) t++; makes no sense when a & b are constant. Mind you, I've got no idea about what this code actually does, so I've no idea what the author was intending...... but I doubt the above code expresses that intention correctly. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200005260552.PAA20510>