From owner-freebsd-current@freebsd.org  Wed Jul  8 09:09:39 2015
Return-Path: <owner-freebsd-current@freebsd.org>
Delivered-To: freebsd-current@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 398619954FC
 for <freebsd-current@mailman.ysv.freebsd.org>;
 Wed,  8 Jul 2015 09:09:39 +0000 (UTC)
 (envelope-from darius@dons.net.au)
Received: from ipmail04.adl6.internode.on.net (ipmail04.adl6.internode.on.net
 [150.101.137.141])
 by mx1.freebsd.org (Postfix) with ESMTP id C4BC11237
 for <freebsd-current@freebsd.org>; Wed,  8 Jul 2015 09:09:38 +0000 (UTC)
 (envelope-from darius@dons.net.au)
Received: from ppp14-2-62-119.lns21.adl2.internode.on.net (HELO
 midget.dons.net.au) ([14.2.62.119])
 by ipmail04.adl6.internode.on.net with ESMTP; 08 Jul 2015 18:34:29 +0930
Received: from [10.0.2.26] ([10.0.2.26]) (authenticated bits=0)
 by midget.dons.net.au (8.15.1/8.14.9) with ESMTPSA id t6894MdI084400
 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
 Wed, 8 Jul 2015 18:34:27 +0930 (CST)
 (envelope-from darius@dons.net.au)
Subject: Re: gettimeofday((void *)-1,
 NULL) implicates core dump on recent FreeBSD 11-CURRENT
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2102\))
Content-Type: text/plain; charset=us-ascii
From: "O'Connor, Daniel" <darius@dons.net.au>
In-Reply-To: <201507072241.t67MfsX5085860@hergotha.csail.mit.edu>
Date: Wed, 8 Jul 2015 18:34:22 +0930
Cc: oliver.pinter@hardenedbsd.org, freebsd-current@freebsd.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <94BCDA65-5B86-4329-A312-4CB16E847B69@dons.net.au>
References: <CAPQ4ffuTcN_ytcH7GPY0s6OqWK9qo6MGaVZhOB+0ojWfd=fNCg@mail.gmail.com>
 <201507072241.t67MfsX5085860@hergotha.csail.mit.edu>
To: Garrett Wollman <wollman@hergotha.csail.mit.edu>
X-Mailer: Apple Mail (2.2102)
X-Spam-Score: -2.9 () ALL_TRUSTED,BAYES_00
X-Scanned-By: MIMEDefang 2.75 on 10.0.2.1
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Jul 2015 09:09:39 -0000


> On 8 Jul 2015, at 08:11, Garrett Wollman =
<wollman@hergotha.csail.mit.edu> wrote:
> Perhaps the test was (erroneously) written to assume that
> gettimeofday() was a system call, and could therefore detect invalid
> pointers and return [EFAULT].  This has not been the case for some
> time.  (In HEAD, not since r237434, which is three years ago.)

In defence of the test, the man page says it can return EFAULT.

(IMO the man page and test should change..)

--
Daniel O'Connor
"The nice thing about standards is that there
are so many of them to choose from."
 -- Andrew Tanenbaum
GPG Fingerprint - 5596 B766 97C0 0E94 4347 295E E593 DC20 7B3F CE8C