From owner-svn-src-stable-12@freebsd.org Fri May 22 01:30:17 2020 Return-Path: Delivered-To: svn-src-stable-12@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 32D992FA8E3; Fri, 22 May 2020 01:30:17 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qv1-xf42.google.com (mail-qv1-xf42.google.com [IPv6:2607:f8b0:4864:20::f42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49Spp057sXz4bFl; Fri, 22 May 2020 01:30:16 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qv1-xf42.google.com with SMTP id r3so4069347qve.1; Thu, 21 May 2020 18:30:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=e0owCijb/mxyU4tlNffIfomcbYpMgnINIx1ohlr/NT4=; b=ANxxxtUK6DBZBJ7Sjt4SZkBOjf1lSrfN+hcf3KHzKxa/pJoN7tZ/H4H+d6VbHX60ra Aea7rqSHPKDigDwR22hA0iO4rx+TwWq7eEg1CH6kI1n4CYH0BJ/MOgASkJbEx2g69DtP YoGScDt3qAt6L+V6CFaFHEQBkh8gqqFhQjdVllyw55VzLsAu7k2esUdxtPUqdgfEg1Rh d5z/LZxx8K/Fuyz8basT5ERCo3rrX6+4ZIN9EPYmt7ofy9CBi9QoTENUrdvi5hvKwpzO jV3JEDgePJmGSyKG3FkUp1wU1KgW84qiDInOwP7tvLaDRFh4dumSbreFYLc5cTsrBxtc 5NzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=e0owCijb/mxyU4tlNffIfomcbYpMgnINIx1ohlr/NT4=; b=ZHRLT95TIe4LEyAXhAnvgiyoStgkIyFB9liqOEQ8SYPZfGJ56yEwqmnva17aE9QOT/ RH3ePePAuKE0CEPPieNEO1UQ4ExhNKlt3ugkGPV2vOmXQJv21v/v7/DjL/NfLuTjqYqT RMBpM/ZdbYlU+lhSeqBb9jh46yUKFAI+OIypu8cS6VItruvKcizj4meWKT5dOGVeQqzy xqTyWo0DTGtojlqdQgKNFupMcdlf8qy6H2FGip/86AUiU31+C/Db2HyPw2o6yPpZ6NH9 nQ3l6lBOWcnaPjULFCioaDOpYxJypSmzR2qoI9WU54sabvO9tfCWG4iH/rYxrJ7vwA8C THwg== X-Gm-Message-State: AOAM531DqAin+5p33oaglhl/n2OZvApMtXJqAx+TEQWrsydIMpNJAB0k TKLnsI192Xp9zgm0MLMedHYgXBFNOso= X-Google-Smtp-Source: ABdhPJzxOz63BVIhM0kszB+I0xY4OYopoylAr+SVFY/yCQ6bOQ+DnlMKWbsIT4Qs1cAP5dSUtswvbg== X-Received: by 2002:a0c:aa4b:: with SMTP id e11mr1555265qvb.14.1590111015413; Thu, 21 May 2020 18:30:15 -0700 (PDT) Received: from raichu (toroon0560w-lp130-15-184-144-87-103.dsl.bell.ca. [184.144.87.103]) by smtp.gmail.com with ESMTPSA id a12sm5923769qko.103.2020.05.21.18.30.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2020 18:30:14 -0700 (PDT) Sender: Mark Johnston Date: Thu, 21 May 2020 21:30:12 -0400 From: Mark Johnston To: "Herbert J. Skuhra" Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org Subject: Re: svn commit: r361334 - in stable/12/sys: amd64/amd64 arm64/arm64 dev/acpica i386/i386 x86/acpica Message-ID: <20200522013012.GK85681@raichu> References: <202005211528.04LFSZFF068443@repo.freebsd.org> <87a720aowg.wl-herbert@gojira.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87a720aowg.wl-herbert@gojira.at> X-Rspamd-Queue-Id: 49Spp057sXz4bFl X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=ANxxxtUK; dmarc=none; spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::f42 as permitted sender) smtp.mailfrom=markjdb@gmail.com X-Spamd-Result: default: False [-1.13 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; NEURAL_HAM_MEDIUM(-0.78)[-0.779]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; NEURAL_HAM_LONG(-0.94)[-0.941]; MIME_GOOD(-0.10)[text/plain]; MID_RHS_NOT_FQDN(0.50)[]; DMARC_NA(0.00)[freebsd.org]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_SPAM_SHORT(0.29)[0.290]; DKIM_TRACE(0.00)[gmail.com:+]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::f42:from]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; RECEIVED_SPAMHAUS_PBL(0.00)[184.144.87.103:received]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-src-stable-12@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for only the 12-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 May 2020 01:30:17 -0000 On Fri, May 22, 2020 at 12:45:03AM +0200, Herbert J. Skuhra wrote: > On Thu, 21 May 2020 17:28:35 +0200, Mark Johnston wrote: > > > > Author: markj > > Date: Thu May 21 15:28:35 2020 > > New Revision: 361334 > > URL: https://svnweb.freebsd.org/changeset/base/361334 > > > > Log: > > MFC r361033: > > Call acpi_pxm_set_proximity_info() slightly earlier on x86. > > > > Modified: > > stable/12/sys/amd64/amd64/mp_machdep.c > > stable/12/sys/arm64/arm64/mp_machdep.c > > stable/12/sys/dev/acpica/acpi_pxm.c > > stable/12/sys/dev/acpica/acpivar.h > > stable/12/sys/i386/i386/mp_machdep.c > > stable/12/sys/x86/acpica/srat.c > > Directory Properties: > > stable/12/ (props changed) > > > > Modified: stable/12/sys/amd64/amd64/mp_machdep.c > > ============================================================================== > > --- stable/12/sys/amd64/amd64/mp_machdep.c Thu May 21 15:18:59 2020 (r361333) > > +++ stable/12/sys/amd64/amd64/mp_machdep.c Thu May 21 15:28:35 2020 (r361334) > > @@ -265,8 +265,9 @@ cpu_mp_start(void) > > init_ops.start_all_aps(); > > > > set_interrupt_apic_ids(); > > -} > > > > + acpi_pxm_set_cpu_locality(); > > +} > > > > /* > > * AP CPU's call this to initialize themselves. > > Until now it was possible to build a kernel (amd64) without 'device > acpi'. After this commit it fails with this error: > > --- kernel.full --- > linking kernel.full > ld: error: undefined symbol: acpi_pxm_set_cpu_locality > >>> referenced by mp_machdep.c:269 (/usr/src/sys/amd64/amd64/mp_machdep.c:269) > >>> mp_machdep.o:(cpu_mp_start) > *** [kernel.full] Error code 1 > > Was that intended? It was unintentional. I committed a fix to head in r361352 and will merge to stable/12 shortly.