From owner-freebsd-isdn Mon Sep 2 2: 4:32 2002 Delivered-To: freebsd-isdn@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D699B37B400 for ; Mon, 2 Sep 2002 02:04:30 -0700 (PDT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1142B43E4A for ; Mon, 2 Sep 2002 02:04:30 -0700 (PDT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.3/8.12.2) with ESMTP id g8294KvV040895; Mon, 2 Sep 2002 11:04:22 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: Ari Suutari Cc: Gary Jennejohn , hselasky@c2i.net, freebsd-isdn@FreeBSD.ORG Subject: Re: New ihfc driver In-Reply-To: Your message of "Mon, 02 Sep 2002 09:43:34 +0300." <200209020943.34019.ari.suutari@syncrontech.com> Date: Mon, 02 Sep 2002 11:04:20 +0200 Message-ID: <40894.1030957460@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-freebsd-isdn@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org In message <200209020943.34019.ari.suutari@syncrontech.com>, Ari Suutari writes : >Hi, > >Good that this driver is making progress. Maybe, someday >I can use cards from my pile-of-hfc-based-isdn-cards. > >On Friday 30 August 2002 14:11, Gary Jennejohn wrote: >> hselasky@c2i.net writes: >> >> The stuff you did in the state machines I can't comment on. >> >> The weird dynamic goto's and opaque macros which you use in >> your drivers are IMO not acceptable. If no-one but you understands >> this stuff then we'll have a maintenace nightmare. What if you >> get hit by a truck ? > > A couple of questions come to my mind: > > - if this driver would be added as-is to current distribution, > would it break anything ie. would the worst case be > just that new cards supported by this driver wouldn't work ? I tried, I couldn't get it to compile. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-isdn" in the body of the message