From owner-freebsd-current  Tue Feb 25  5:22:12 2003
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 9D3D737B401; Tue, 25 Feb 2003 05:22:10 -0800 (PST)
Received: from gw.nectar.cc (gw.nectar.cc [208.42.49.153])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id E873D43F3F; Tue, 25 Feb 2003 05:22:09 -0800 (PST)
	(envelope-from nectar@celabo.org)
Received: from madman.celabo.org (madman.celabo.org [10.0.1.111])
	by gw.nectar.cc (Postfix) with ESMTP
	id 737B954; Tue, 25 Feb 2003 07:22:09 -0600 (CST)
Received: by madman.celabo.org (Postfix, from userid 1001)
	id 5FF4478C3E; Tue, 25 Feb 2003 07:22:09 -0600 (CST)
Date: Tue, 25 Feb 2003 07:22:09 -0600
From: "Jacques A. Vidrine" <nectar@FreeBSD.org>
To: Craig Rodrigues <rodrigc@attbi.com>
Cc: markm@FreeBSD.org, freebsd-current@freebsd.org
Subject: Re: OpenSSL should define OPENSSL_THREADS?
Message-ID: <20030225132209.GB95282@madman.celabo.org>
Mail-Followup-To: "Jacques A. Vidrine" <nectar@FreeBSD.org>,
	Craig Rodrigues <rodrigc@attbi.com>, markm@FreeBSD.org,
	freebsd-current@freebsd.org
References: <20030225025821.GA4399@attbi.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030225025821.GA4399@attbi.com>
X-Url: http://www.celabo.org/
User-Agent: Mutt/1.5.3i-ja.1
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

On Mon, Feb 24, 2003 at 09:58:21PM -0500, Craig Rodrigues wrote:
> Hi,
> 
> I ran a cvsup of -CURRENT a few days ago.
> 
> I have some code which assumes that OPENSSL_THREADS is defined if
> the OpenSSL version is greater than 0.9.7:
> 
> #define OPENSSL_THREAD_DEFINES
> #include <openssl/opensslconf.h>
> #include <openssl/opensslv.h>
> #if OPENSSL_VERSION_NUMBER < 0x0090700fL
> #   if !defined(THREADS)  
> #      error "Thread support not enabled"
> #   endif
> #else
> #   if !defined(OPENSSL_THREADS)
> #      error "Thread support not enabled"
> #   endif
> #endif
> 
> 
> Should the OpenSSL in FreeBSD be defining OPENSSL_THREADS?

I think you may be right.  OpenSSL 0.9.7's out-of-the box configure
creates an opensslconf.h that would define OPENSSL_THREADS on FreeBSD.

Mark supplied the opensslconf.h's that are used in the FreeBSD build ...
let's see if this is intentional or not. [cc'd]

Cheers,
-- 
Jacques A. Vidrine <nectar@celabo.org>          http://www.celabo.org/
NTT/Verio SME          .     FreeBSD UNIX     .       Heimdal Kerberos
jvidrine@verio.net     .  nectar@FreeBSD.org  .          nectar@kth.se

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message