From owner-freebsd-rc@FreeBSD.ORG Sat Jan 7 11:26:46 2012 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 57F59106566B for ; Sat, 7 Jan 2012 11:26:46 +0000 (UTC) (envelope-from pawel@dawidek.net) Received: from mail.dawidek.net (60.wheelsystems.com [83.12.187.60]) by mx1.freebsd.org (Postfix) with ESMTP id F11138FC0C for ; Sat, 7 Jan 2012 11:26:45 +0000 (UTC) Received: from localhost (58.wheelsystems.com [83.12.187.58]) by mail.dawidek.net (Postfix) with ESMTPSA id 6DEE01A2; Sat, 7 Jan 2012 12:26:44 +0100 (CET) Date: Sat, 7 Jan 2012 12:25:38 +0100 From: Pawel Jakub Dawidek To: Doug Barton Message-ID: <20120107112538.GC1696@garage.freebsd.pl> References: <20120106141301.GE1693@garage.freebsd.pl> <4F079A76.3030306@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Qrgsu6vtpU/OV/zm" Content-Disposition: inline In-Reply-To: <4F079A76.3030306@FreeBSD.org> X-OS: FreeBSD 9.0-CURRENT amd64 User-Agent: Mutt/1.5.21 (2010-09-15) Cc: freebsd-rc@FreeBSD.org Subject: Re: Making use of set_rcvar. X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Jan 2012 11:26:46 -0000 --Qrgsu6vtpU/OV/zm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 06, 2012 at 05:05:58PM -0800, Doug Barton wrote: > On 01/06/2012 06:13, Pawel Jakub Dawidek wrote: > > Any objections? > >=20 > > http://people.freebsd.org/~pjd/patches/set_rcvar.patch > >=20 > > This patch only changes scripts where set_rcvar can be used with no > > arguments. >=20 > Please don't do this. >=20 > Jilles already pointed out the important reason, it adds pointless > forks. I suggested a long time ago that we remove set_rcvar altogether > but I got a lot of resistance to it, and never pursued it. Perhaps it's > time to revisit that. It is a total mess now then and it is definiately not intuitive when there are much more bad examples than good ones: % grep -r ^rcvar /usr/src/etc/rc.d | grep set_rcvar | wc -l 66 % grep -r ^rcvar /usr/src/etc/rc.d | grep -v set_rcvar | wc -l 34 > In regards to your concern about not having to type the name of the > script when copying to create a new one, you can't really be serious > about that? If so, let me introduce you to this revolutionary thing > called "search and replace." Do you really expect me to comment this? --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com --Qrgsu6vtpU/OV/zm Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAk8IK7EACgkQForvXbEpPzTqTwCcCcKfXAnfbgCCJYkqZzKTEmlY vakAniEZ3Xoduq+14Wwe710WaXlPtBOn =KnoQ -----END PGP SIGNATURE----- --Qrgsu6vtpU/OV/zm--