From owner-freebsd-wireless@FreeBSD.ORG Fri Dec 30 18:40:53 2011 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F21CE1065677 for ; Fri, 30 Dec 2011 18:40:53 +0000 (UTC) (envelope-from stpere@gmail.com) Received: from mail-ey0-f182.google.com (mail-ey0-f182.google.com [209.85.215.182]) by mx1.freebsd.org (Postfix) with ESMTP id 823748FC17 for ; Fri, 30 Dec 2011 18:40:53 +0000 (UTC) Received: by eaaf13 with SMTP id f13so18140593eaa.13 for ; Fri, 30 Dec 2011 10:40:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; bh=uyxI/v2U+8R/sLaY36rDti5EpSYVqTfxCqUZetTTmN8=; b=eVFFwaWAgeLPeBCAX5KLXzPjb7oF0CDfECKf4pkSoRHS4dPXWyTZ8RqL2XK77BLSRz Y7LNMg8jyK2XO+rXT4h9aJUBqj5u6lLffNR6pCRfVBP1FhMAg4GW++/uzQbkD/fPtlmZ KfJXkjieL0JT73qd288gwUtd/+iBiWPAauSjQ= MIME-Version: 1.0 Received: by 10.205.135.18 with SMTP id ie18mr2143341bkc.72.1325268629162; Fri, 30 Dec 2011 10:10:29 -0800 (PST) Received: by 10.204.155.134 with HTTP; Fri, 30 Dec 2011 10:10:28 -0800 (PST) Date: Fri, 30 Dec 2011 13:10:28 -0500 Message-ID: From: Philippe Saint-Pierre To: freebsd-wireless@freebsd.org Content-Type: multipart/mixed; boundary=000e0ce03d52df899904b5532567 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Subject: patch proposal for marvell driver X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Dec 2011 18:40:54 -0000 --000e0ce03d52df899904b5532567 Content-Type: text/plain; charset=ISO-8859-1 Hi, I'm sending this small patch for the marvell wifi driver. Basically, in mwl_hal_bastream_alloc(), there is a sp = ... assignment that could return NULL, then several derefencing of sp then finally, a NULL check on sp before returning. I simply moved the NULL check before the dereferences tries occurs. Thank you! -- Philippe Saint-Pierre --000e0ce03d52df899904b5532567--