Date: Mon, 11 Aug 2014 12:27:00 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 191511] opiepasswd(1) segfaults with a seed length > 12 Message-ID: <bug-191511-8-SaFOPdBk9y@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-191511-8@https.bugs.freebsd.org/bugzilla/> References: <bug-191511-8@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191511 --- Comment #1 from commit-hook@freebsd.org --- A commit references this bug: Author: ache Date: Mon Aug 11 12:26:49 UTC 2014 New revision: 269806 URL: http://svnweb.freebsd.org/changeset/base/269806 Log: Fix too long (seed length >12 chars) challenge handling. 1) " ext" length should be included into OPIE_CHALLENGE_MAX (as all places of opie code expects that). 2) Overflow check in challenge.c is off by 1 even with corrected OPIE_CHALLENGE_MAX 3) When fallback to randomchallenge() happens and rval is 0 (i.e. challenge is too long), its value should be set to error state too. To demonstrate the bug, run opiepasswd with valid seed: opiepasswd -s 1234567890123456 and notice that it falls back to randomchallenge() (i.e. no 1234567890123456 in the prompt). PR: 191511 Submitted by: mitsururike@gmail.com (partially) MFC after: 1 week Changes: head/contrib/opie/libopie/challenge.c head/contrib/opie/opie.h -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-191511-8-SaFOPdBk9y>