From owner-cvs-all  Wed Dec 23 23:50:12 1998
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id XAA28148
          for cvs-all-outgoing; Wed, 23 Dec 1998 23:50:12 -0800 (PST)
          (envelope-from owner-cvs-all@FreeBSD.ORG)
Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.26.10.9])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id XAA28142;
          Wed, 23 Dec 1998 23:50:06 -0800 (PST)
          (envelope-from bde@godzilla.zeta.org.au)
Received: (from bde@localhost)
	by godzilla.zeta.org.au (8.8.7/8.8.7) id SAA07787;
	Thu, 24 Dec 1998 18:49:53 +1100
Date: Thu, 24 Dec 1998 18:49:53 +1100
From: Bruce Evans <bde@zeta.org.au>
Message-Id: <199812240749.SAA07787@godzilla.zeta.org.au>
To: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, foxfair@FreeBSD.ORG
Subject: Re: cvs commit: src/sys/i386/isa wd.c
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

>  Modified files:
>    sys/i386/isa         wd.c 
>  Log:
>  Correct the wrong PCI-IDE probing on AcerLabs Aladdin-V chipset. It won't
>  change the original code but add an extra option "ALI_V" to check the
>  precise IDE port.(especially, secondary) Use the same option "ALI_V" on
>  the kernel config file to prevent generic DMA check causes wrong result.
>  (It seems buggy even on PIIX4 chipset, and I don't know when this bug start)
>  
>  Should I add the option "ALI_V" into /sys/i386/conf/LINT ?

No.  There shouldn't be any options for this.  Just fix the code.  The
existing nonstandard option DISABLE_PCI_IDE shouldn't exist either (I
think it doesn't actually disable PCI IDE, since PCI IDE is set up
correctly later (if possible).)

Your patch seems to be a no-op anyway, since the new code that sets
dk_altport correctly is undone by executing the old code afterwards.
This is all obfuscated by misindenting of the old code in the patch,
ifdefs, and style bugs.  E.g., dk_port is now set 5 times to the same
value in various arms of the #ifdefs and ifs.  Previously it was only
set 3 times.  dk_altport is set 5 times to 2 values, and the bug is
that it is sometmes set to 0.

Bruce

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message