From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Jun 30 15:00:22 2003 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9E37537B407 for ; Mon, 30 Jun 2003 15:00:22 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2501E43FF9 for ; Mon, 30 Jun 2003 15:00:20 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h5UM0JUp007385 for ; Mon, 30 Jun 2003 15:00:19 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h5UM0Jsq007380; Mon, 30 Jun 2003 15:00:19 -0700 (PDT) Resent-Date: Mon, 30 Jun 2003 15:00:19 -0700 (PDT) Resent-Message-Id: <200306302200.h5UM0Jsq007380@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Scott Mitchell Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 90AB937B401 for ; Mon, 30 Jun 2003 14:51:55 -0700 (PDT) Received: from mta03-svc.ntlworld.com (mta03-svc.ntlworld.com [62.253.162.43]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6DF6943F93 for ; Mon, 30 Jun 2003 14:51:52 -0700 (PDT) (envelope-from scott@fishballoon.org) Received: from fishballoon.org ([81.104.195.199]) by mta03-svc.ntlworld.com (InterMail vM.4.01.03.37 201-229-121-137-20020806) with ESMTP id <20030630215151.GCEF2652.mta03-svc.ntlworld.com@fishballoon.org> for ; Mon, 30 Jun 2003 22:51:51 +0100 Received: from tuatara.fishballoon.org (tuatara [192.168.1.6]) by fishballoon.org (8.12.8p1/8.12.8) with ESMTP id h5ULp3sL071428 for ; Mon, 30 Jun 2003 22:51:03 +0100 (BST) (envelope-from scott@tuatara.fishballoon.org) Received: (from scott@localhost) by tuatara.fishballoon.org (8.12.9/8.12.9/Submit) id h5ULp3EW006372; Mon, 30 Jun 2003 22:51:03 +0100 (BST) (envelope-from scott) Message-Id: <200306302151.h5ULp3EW006372@tuatara.fishballoon.org> Date: Mon, 30 Jun 2003 22:51:03 +0100 (BST) From: Scott Mitchell To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: ports/53939: [PATCH] Fix library dependencies in samba-devel port X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Scott Mitchell List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jun 2003 22:00:23 -0000 >Number: 53939 >Category: ports >Synopsis: [PATCH] Fix library dependencies in samba-devel port >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Jun 30 15:00:19 PDT 2003 >Closed-Date: >Last-Modified: >Originator: Scott Mitchell >Release: FreeBSD 4.8-STABLE i386 >Organization: >Environment: System: FreeBSD tuatara 4.8-STABLE FreeBSD 4.8-STABLE #0: Sun Apr 13 14:23:25 BST 2003 scott@tuatara:/local/0/obj/usr/src/sys/TUATARA i386 >Description: The net/samba-devel port has a WITHOUT_CUPS Makefile option that drops the *port's* dependency on the CUPS library, but does not actually pass the option to configure to build Samba without CUPS support. The resulting binaries will still have a runtime dependency on the CUPS library. Similarly, the binaries built by the port have a runtime dependency on the popt (port devel/popt) library which is not listed in the Makefile. >How-To-Repeat: # cd /usr/ports/net/samba-devel # make -DWITHOUT_CUPS package Then install the resulting package on a machine that does not have CUPS and/or popt installed. The package will install without complaint but smdb, nmdb, etc. will not run due to the unsatisfied runtime library dependencies. >Fix: The attached patch: 1. Passes the --enable-cups=no option to configure when WITHOUT_CUPS is specified. 2. Adds a new WITHOUT_POPT Makefile option. If this is specified, the --with-included-popt option is passed to configure, to build Samba using its internal popt implementation rather than the port. If WITHOUT_POPT is not specified, the popt library from devel/popt is added to LIB_DEPENDS. Index: ports/net/samba-devel/Makefile =================================================================== RCS file: /home/ncvs/ports/net/samba-devel/Makefile,v retrieving revision 1.91 diff -u -r1.91 Makefile --- ports/net/samba-devel/Makefile 24 Mar 2003 19:02:34 -0000 1.91 +++ ports/net/samba-devel/Makefile 30 Jun 2003 21:35:51 -0000 @@ -50,6 +50,10 @@ .include +.if defined(WITHOUT_CUPS) +CONFIGURE_ARGS+= --enable-cups=no +.endif + .if defined(WITH_QUOTAS) CONFIGURE_ARGS+= --with-quotas .endif @@ -87,6 +91,12 @@ .if defined(WITH_LIBICONV) LIB_DEPENDS+= iconv.3:${PORTSDIR}/converters/libiconv CONFIGURE_ARGS+= --with-libiconv +.endif + +.if defined(WITHOUT_POPT) +CONFIGURE_ARGS+= --with-included-popt +.else +LIB_DEPENDS+= popt.0:${PORTSDIR}/devel/popt .endif WRKSRC= ${WRKDIR}/${DISTNAME}/source >Release-Note: >Audit-Trail: >Unformatted: