From owner-cvs-all  Mon Apr 15 16:14:57 2002
Delivered-To: cvs-all@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id 87D5B37B404; Mon, 15 Apr 2002 16:14:52 -0700 (PDT)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id JAA15231;
	Tue, 16 Apr 2002 09:14:50 +1000
Date: Tue, 16 Apr 2002 09:15:19 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: "David E. O'Brien" <obrien@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, <cvs-all@FreeBSD.org>
Subject: Re: cvs commit: src/usr.bin/make str.c
In-Reply-To: <200204130949.g3D9nYE31181@freefall.freebsd.org>
Message-ID: <20020416090400.G6024-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Sat, 13 Apr 2002, David E. O'Brien wrote:

> obrien      2002/04/13 02:49:34 PDT
>
>   Modified files:
>     usr.bin/make         str.c
>   Log:
>   Constify str_concat()
>
>   Submitted by:   jmallett
>
>   Revision  Changes    Path
>   1.15      +4 -4      src/usr.bin/make/str.c

This is another example of wrong WARNSification.  str_concat() doesn't
actually take const char * args any more than free() takes a const void *
arg, since it sometimes frees its args.

This also breaks bootstrapping from RELENG_4 by using the __DECONST()
mistake.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message