Date: Mon, 21 Apr 2008 18:01:44 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: phk@phk.freebsd.dk Cc: cvs-src@FreeBSD.org, jmg@funkthat.com, bz@FreeBSD.org, cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/ata ata-all.c Message-ID: <20080421.180144.-1676909581.imp@bsdimp.com> In-Reply-To: <99531.1208814953@critter.freebsd.dk> References: <20080421213724.GL82555@funkthat.com> <99531.1208814953@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <99531.1208814953@critter.freebsd.dk> "Poul-Henning Kamp" <phk@phk.freebsd.dk> writes: : In message <20080421213724.GL82555@funkthat.com>, John-Mark Gurney writes: : : >Any one object to changing: : >.Nm devclass_get_maxunit : >.Nd find the maximum unit number in the class : > : >to: : >.Nm devclass_get_maxunit : >.Nd find the next free unit number in the class : : Those are very different semantics, the name should change as well : then. The change isn't in semantics of the function call. It is just the description of what it does. Agreed that it is a bad interface name.. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080421.180144.-1676909581.imp>