From owner-freebsd-current@FreeBSD.ORG Sat Feb 17 17:07:41 2007 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 82DD516A401 for ; Sat, 17 Feb 2007 17:07:41 +0000 (UTC) (envelope-from rodrigc@crodrigues.org) Received: from alnrmhc12.comcast.net (alnrmhc12.comcast.net [206.18.177.52]) by mx1.freebsd.org (Postfix) with ESMTP id 5565413C441 for ; Sat, 17 Feb 2007 17:07:40 +0000 (UTC) (envelope-from rodrigc@crodrigues.org) Received: from c-66-31-35-94.hsd1.ma.comcast.net ([66.31.35.94]) by comcast.net (alnrmhc12) with ESMTP id <20070217170739b12001l496e>; Sat, 17 Feb 2007 17:07:40 +0000 Received: from c-66-31-35-94.hsd1.ma.comcast.net (localhost.crodrigues.org [127.0.0.1]) by c-66-31-35-94.hsd1.ma.comcast.net (8.13.8/8.13.8) with ESMTP id l1HH7iLY028605; Sat, 17 Feb 2007 12:07:44 -0500 (EST) (envelope-from rodrigc@c-66-31-35-94.hsd1.ma.comcast.net) Received: (from rodrigc@localhost) by c-66-31-35-94.hsd1.ma.comcast.net (8.13.8/8.13.8/Submit) id l1HH7h0r028604; Sat, 17 Feb 2007 12:07:43 -0500 (EST) (envelope-from rodrigc) Date: Sat, 17 Feb 2007 12:07:43 -0500 From: Craig Rodrigues To: Olivier Houchard Message-ID: <20070217170743.GA28585@crodrigues.org> References: <790a9fff0702161738r154b5087m877c604092727e39@mail.gmail.com> <20070217021629.GA24579@ci0.org> <20070217162233.GA28315@crodrigues.org> <20070217164904.GA31437@ci0.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070217164904.GA31437@ci0.org> User-Agent: Mutt/1.4.2.1i Cc: Scot Hetzel , FreeBSD Current Subject: Re: mount_ntfs: /dev/ad0s1: No such file or directory X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Feb 2007 17:07:41 -0000 On Sat, Feb 17, 2007 at 05:49:04PM +0100, Olivier Houchard wrote: > Apparently not enough ;-) > I'm in discussion with Bruce Evans about this, he brought up valid concerns > about this change, maybe I'll revert it and check all consumers of vfs_getopts > to make sure they check the return value instead. I'm not opposed to your vfs_mount.c change since it is quite reasonable. It's just that in the mount code in FreeBSD, over the years, a lot of behavior has been built on unreasonable API's, so changing things exposes weird bugs. :) mount_ntfs should probably be converted to properly use nmount() like mount_msdosfs. The nmount() call path in the ntfs file system code should probably be fixed up too. I don't have any NTFS partitions on my FreeBSD system. Does someone have a small NTFS disk image that they can send me so I can implement some of these changes and practise mounting? -- Craig Rodrigues rodrigc@crodrigues.org