From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Nov 10 09:40:02 2008 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 22B681065679 for ; Mon, 10 Nov 2008 09:40:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id EDFD28FC13 for ; Mon, 10 Nov 2008 09:40:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id mAA9e1AL081101 for ; Mon, 10 Nov 2008 09:40:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id mAA9e1b3081100; Mon, 10 Nov 2008 09:40:01 GMT (envelope-from gnats) Resent-Date: Mon, 10 Nov 2008 09:40:01 GMT Resent-Message-Id: <200811100940.mAA9e1b3081100@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Joseph S. Atkinson" Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C7C1A1065673 for ; Mon, 10 Nov 2008 09:30:47 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id B23CE8FC21 for ; Mon, 10 Nov 2008 09:30:47 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id mAA9UlX8033348 for ; Mon, 10 Nov 2008 09:30:47 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id mAA9UlKV033347; Mon, 10 Nov 2008 09:30:47 GMT (envelope-from nobody) Message-Id: <200811100930.mAA9UlKV033347@www.freebsd.org> Date: Mon, 10 Nov 2008 09:30:47 GMT From: "Joseph S. Atkinson" To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/128747: multimedia/vlc-devel fix conflicting WITH_SKINS + WITHOUT_QT4 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Nov 2008 09:40:02 -0000 >Number: 128747 >Category: ports >Synopsis: multimedia/vlc-devel fix conflicting WITH_SKINS + WITHOUT_QT4 >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: maintainer-update >Submitter-Id: current-users >Arrival-Date: Mon Nov 10 09:40:00 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Joseph S. Atkinson >Release: >Organization: >Environment: >Description: If a user opts not to build the QT interface, but has opted for the skinnable UI, configure fails. This informs people selecting these via the OPTIONS framework that QT4 is required for SKINS. If a user defines both anyway via `make config` or in the environment, then WITH_SKINS will be silently ignored in favor of honoring WITHOUT_QT4. No need to bump PORTREVISION. Discovered reviewing config.log sent via private email. Thanks A. B. >How-To-Repeat: >Fix: Patch attached with submission follows: --- Makefile.orig 2008-11-10 03:32:26.000000000 -0500 +++ Makefile 2008-11-10 04:04:26.000000000 -0500 @@ -51,7 +51,7 @@ OPTIONS+= SVG "SVG graphics support" Off OPTIONS+= SVGALIB "SVGALIB video output" Off OPTIONS+= SHOUT "Shout2 support" Off -OPTIONS+= SKINS "Enable winamp skins interface" Off +OPTIONS+= SKINS "Enable winamp skins interface (requires QT4)" Off OPTIONS+= SPEEX "Speex voice codec support" On OPTIONS+= THEORA "OGG/Vorbis video codec support" On OPTIONS+= TWOLAME "Twolame mpeg2 audio encoder support" On @@ -165,7 +165,7 @@ CONFIGURE_ARGS+=--disable-notify .endif -.if defined(WITH_SKINS) && !defined(WITHOUT_SKINS) +.if defined(WITH_SKINS) && !defined(WITHOUT_SKINS) && !defined(WITHOUT_QT4) CONFIGURE_ARGS+=--enable-skins2 .else CONFIGURE_ARGS+=--disable-skins2 >Release-Note: >Audit-Trail: >Unformatted: