From owner-svn-src-head@FreeBSD.ORG Sun Dec 28 04:51:01 2008 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4D543106564A; Sun, 28 Dec 2008 04:51:01 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from pele.citylink.co.nz (pele.citylink.co.nz [202.8.44.226]) by mx1.freebsd.org (Postfix) with ESMTP id 0B2DD8FC13; Sun, 28 Dec 2008 04:51:01 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from localhost (localhost [127.0.0.1]) by pele.citylink.co.nz (Postfix) with ESMTP id BB8E9FEF3; Sun, 28 Dec 2008 17:50:59 +1300 (NZDT) X-Virus-Scanned: Debian amavisd-new at citylink.co.nz Received: from pele.citylink.co.nz ([127.0.0.1]) by localhost (pele.citylink.co.nz [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ryz7mACwc+1Q; Sun, 28 Dec 2008 17:50:55 +1300 (NZDT) Received: from citylink.fud.org.nz (unknown [202.8.44.45]) by pele.citylink.co.nz (Postfix) with ESMTP; Sun, 28 Dec 2008 17:50:55 +1300 (NZDT) Received: by citylink.fud.org.nz (Postfix, from userid 1001) id 3C76C1142B; Sun, 28 Dec 2008 17:50:55 +1300 (NZDT) Date: Sat, 27 Dec 2008 20:50:55 -0800 From: Andrew Thompson To: Stanislav Sedov Message-ID: <20081228045055.GA81182@citylink.fud.org.nz> References: <200812272048.mBRKmBKo082102@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200812272048.mBRKmBKo082102@svn.freebsd.org> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r186529 - head/sys/dev/acpi_support X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Dec 2008 04:51:01 -0000 On Sat, Dec 27, 2008 at 08:48:11PM +0000, Stanislav Sedov wrote: > Author: stas > Date: Sat Dec 27 20:48:11 2008 > New Revision: 186529 > URL: http://svn.freebsd.org/changeset/base/186529 > > Log: > - Fix incorrect array declaration that was causing the stack overflow > on some (most?) Asus laptops. > > Discussed with: rpaulo > Approved by: kib (mentor) > MFC after: 2 weeks > > Modified: > head/sys/dev/acpi_support/acpi_asus.c > > Modified: head/sys/dev/acpi_support/acpi_asus.c > ============================================================================== > --- head/sys/dev/acpi_support/acpi_asus.c Sat Dec 27 20:37:53 2008 (r186528) > +++ head/sys/dev/acpi_support/acpi_asus.c Sat Dec 27 20:48:11 2008 (r186529) > @@ -976,7 +976,7 @@ acpi_asus_sysctl_set(struct acpi_asus_so > { > ACPI_STATUS status = AE_OK; > ACPI_OBJECT_LIST acpiargs; > - ACPI_OBJECT acpiarg[0]; > + ACPI_OBJECT acpiarg[1]; > > ACPI_FUNCTION_TRACE((char *)(uintptr_t)__func__); > ACPI_SERIAL_ASSERT(asus); Thanks! I have had panics that I think are related to this. Andrew