From owner-freebsd-current@FreeBSD.ORG  Sat Apr 29 21:28:49 2006
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@FreeBSD.org
Delivered-To: freebsd-current@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 537E516A40A
	for <freebsd-current@FreeBSD.org>; Sat, 29 Apr 2006 21:28:49 +0000 (UTC)
	(envelope-from marcus@FreeBSD.org)
Received: from creme-brulee.marcuscom.com (creme-brulee.marcuscom.com
	[24.172.16.118])
	by mx1.FreeBSD.org (Postfix) with ESMTP id D693743D6A
	for <freebsd-current@FreeBSD.org>; Sat, 29 Apr 2006 21:28:43 +0000 (GMT)
	(envelope-from marcus@FreeBSD.org)
Received: from shumai.marcuscom.com (shumai.marcuscom.com [192.168.1.4])
	by creme-brulee.marcuscom.com (8.13.6/8.13.6) with ESMTP id
	k3TLU95J007902
	for <freebsd-current@freebsd.org>; Sat, 29 Apr 2006 17:30:09 -0400 (EDT)
	(envelope-from marcus@FreeBSD.org)
From: Joe Marcus Clarke <marcus@FreeBSD.org>
To: freebsd-current@FreeBSD.org
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-letydybKu0mE5nEAPMfi"
Organization: FreeBSD, Inc.
Date: Sat, 29 Apr 2006 17:28:40 -0400
Message-Id: <1146346120.16564.12.camel@shumai.marcuscom.com>
Mime-Version: 1.0
X-Mailer: Evolution 2.4.2.1 FreeBSD GNOME Team Port 
Cc: 
Subject: File descriptor leak in libcam
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Apr 2006 21:28:50 -0000


--=-letydybKu0mE5nEAPMfi
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

There is a leak in the cam_lookup_pass() if the ioctl call fails to find
the passthru device.  Basically, the xpt file descriptor will not be
closed.  Can anyone give me permission to commit the following patch?
Thanks.

http://www.marcuscom.com/downloads/camlib.c.diff

Joe

--=20
Joe Marcus Clarke
FreeBSD GNOME Team      ::      gnome@FreeBSD.org
FreeNode / #freebsd-gnome
http://www.FreeBSD.org/gnome

--=-letydybKu0mE5nEAPMfi
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (FreeBSD)

iD8DBQBEU9qIb2iPiv4Uz4cRAml5AKCd1Gherl0V2JWMKz9d6/TuvZ5OnACfSWhG
o0qVpdxVW2EPvlOCVdcPnHI=
=bIEk
-----END PGP SIGNATURE-----

--=-letydybKu0mE5nEAPMfi--