From owner-freebsd-arm@FreeBSD.ORG Fri Jun 29 04:45:28 2012 Return-Path: Delivered-To: arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 24B521065670 for ; Fri, 29 Jun 2012 04:45:28 +0000 (UTC) (envelope-from kientzle@freebsd.org) Received: from monday.kientzle.com (99-115-135-74.uvs.sntcca.sbcglobal.net [99.115.135.74]) by mx1.freebsd.org (Postfix) with ESMTP id F0DB38FC0C for ; Fri, 29 Jun 2012 04:45:27 +0000 (UTC) Received: (from root@localhost) by monday.kientzle.com (8.14.4/8.14.4) id q5T4jHCb054772; Fri, 29 Jun 2012 04:45:17 GMT (envelope-from kientzle@freebsd.org) Received: from [192.168.2.143] (CiscoE3000 [192.168.1.65]) by kientzle.com with SMTP id y7bq9mf9gcwk5aub8xhhj3pacs; Fri, 29 Jun 2012 04:45:17 +0000 (UTC) (envelope-from kientzle@freebsd.org) Mime-Version: 1.0 (Apple Message framework v1278) Content-Type: text/plain; charset=us-ascii From: Tim Kientzle In-Reply-To: <3AB368CC-BE8B-4058-A342-763B8C073800@bsdimp.com> Date: Thu, 28 Jun 2012 21:45:17 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <576FE101-93B7-46D6-B38D-A28EF18CFFC2@freebsd.org> References: <1340921715.1110.100.camel@revolution.hippie.lan> <3AB368CC-BE8B-4058-A342-763B8C073800@bsdimp.com> To: Warner Losh X-Mailer: Apple Mail (2.1278) Cc: arm@freebsd.org Subject: Re: Naming mess... X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jun 2012 04:45:28 -0000 On Jun 28, 2012, at 3:31 PM, Warner Losh wrote: > On Jun 28, 2012, at 4:15 PM, Ian Lepore wrote: > On Tue, 2012-06-26 at 22:21 -0700, Tim Kientzle wrote: >>>=20 >>> Here's what I would like to do: >>>=20 >>> * The first is a given and we should leave it alone. The patches = I'm cleaning up make this useful in the armv6 tree. >>>=20 >>> * The second I would like to move out of asm.h so it can be used in = C code. I would like to rename it to _HAVE_ARMv6_INSTRUCTIONS, which I = think is clearer. I have renamed it in my patches but not yet moved it = to another header. Suggestions appreciated. >>>=20 >>> "NEED_ARM_ARCH_6_SUPPORT" * Someday, I would like to rename the = third one, though I don't have a concrete proposal yet. = ("NEED_ARM_ARCH_6_SUPPORT" is expressive but wordy; better suggestions = appreciated.) >>>=20 >>> Cheers, >>>=20 >>> Tim >>>=20 >>> [0] This page has a nice table: = https://wiki.edubuntu.org/ARM/Thumb2PortingHowto >>>=20 >>=20 >> I'm not working with armv6 stuff yet, but I like all of what you >> propose. I can't help but note that NEED_ARM_ARCH_6_SUPPORT is = actually >> shorter than _HAVE_ARMv6_INSTRUCTIONS. If it's just too wordy, maybe >> the "NEED_" part could be left off. =20 >=20 > #define ARM_ARCH 6 >=20 > #if ARM_ARCH >=3D 6 > ... > #endif >=20 > Might not be the worst idea... I don't think ARM ISA versions are completely well ordered. I seem to recall seeing a few cases where "later" processors have dropped instructions that were present in "earlier" processors. Tim