From owner-freebsd-bugs@FreeBSD.ORG Sun Jun 8 08:30:20 2003 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A9C3B37B401 for ; Sun, 8 Jun 2003 08:30:20 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3329343FB1 for ; Sun, 8 Jun 2003 08:30:20 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h58FUJUp036065 for ; Sun, 8 Jun 2003 08:30:19 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h58FUJXS036062; Sun, 8 Jun 2003 08:30:19 -0700 (PDT) Date: Sun, 8 Jun 2003 08:30:19 -0700 (PDT) Message-Id: <200306081530.h58FUJXS036062@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Maxim Konovalov Subject: Re: misc/51955: pccard_ether textual errors (fwd) X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Maxim Konovalov List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Jun 2003 15:30:20 -0000 The following reply was made to PR misc/51955; it has been noted by GNATS. From: Maxim Konovalov To: bug-followup@freebsd.org Cc: Subject: Re: misc/51955: pccard_ether textual errors (fwd) Date: Sun, 8 Jun 2003 19:23:29 +0400 (MSD) Add to the audit trail. -- Maxim Konovalov, maxim@macomnet.ru, maxim@FreeBSD.org ---------- Forwarded message ---------- Date: Sun, 8 Jun 2003 17:05:42 +0200 (CEST) From: Xander To: Maxim Konovalov Subject: Re: misc/51955: pccard_ether textual errors On Thu, 5 Jun 2003, Maxim Konovalov wrote: + On Thu, 8 May 2003, 10:20-0700, Xander wrote: + [...] + > >Description: + > The comment in pccard_ether (rev 1.29) at the top mentions a third argument + > for 'ifconfig_option'. This argument appears to be unused in the script. + + It is used, actually. Take a look at the line #87: + + # Do the primary ifconfig if specified + ifconfig ${interface} ${ifconfig_args} $* + -------------------------------------------------------^^ Ah yes, I must have missed that one, wishful thinking probably, I needed the argument array ($*) for a quick'n dirty fix later on in the script. Since ume-san since then provided a much better solution for the problem I had (rcNG didn't setup IPv6 networking) that's not needed anymore. + > -# example: pccard_ether ep0 start -link0 + > +# example: pccard_ether ep0 start + + Funny but ep(4) does not support link0 option. + + What do you think about following patch: + + Index: etc/pccard_ether + =================================================================== + RCS file: /home/ncvs/src/etc/pccard_ether,v + retrieving revision 1.30 + diff -u -r1.30 pccard_ether + --- etc/pccard_ether 12 May 2003 11:36:49 -0000 1.30 + +++ etc/pccard_ether 5 Jun 2003 08:28:12 -0000 + @@ -4,7 +4,7 @@ + # + # pccard_ether interfacename [start|stop] [ifconfig option] + # + -# example: pccard_ether ep0 start -link0 + +# example: pccard_ether fxp0 start -link0 + # + + stop_dhcp() { + @@ -156,7 +156,7 @@ + stop_dhcp + ;; + *) + - # Delelte static route if specified + + # Delete static route if specified + eval ifx_routes=\$static_routes_${interface} + if [ -n "${ifx_routes}" ]; then + for i in ${ifx_routes}; do + + %%% Looks fine to me. Thanks for looking into this. -- Xander